Clean up non-MD code paths related to buttons in ash/common/system/tray/tray_popup_utils.cc.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/184394b156baaeb9ea061711192b5a5cae697505 commit 184394b156baaeb9ea061711192b5a5cae697505 Author: estade <estade@chromium.org> Date: Tue Feb 07 19:13:24 2017 Remove some pre-md code from TrayPopupUtils and UserView. Consolidate some button configuration between tray label buttons and tray image buttons (TrayPopupBorderlessButton and SystemMenuButton). Note some of the label button border assets are still being used until crbug.com/686261 is addressed. BUG= 686288 Review-Url: https://codereview.chromium.org/2675893002 Cr-Commit-Position: refs/heads/master@{#448687} [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ash/common/system/chromeos/audio/volume_view.cc [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ash/common/system/tray/system_menu_button.cc [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ash/common/system/tray/tray_popup_utils.h [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ash/common/system/user/user_view.cc [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ash/resources/ash_resources.grd [delete] https://crrev.com/cfc62226b8b375088327fd872c621e90f36f4d7f/ash/resources/default_100_percent/common/tray_popup_public_account_logout_button_border.png [delete] https://crrev.com/cfc62226b8b375088327fd872c621e90f36f4d7f/ash/resources/default_200_percent/common/tray_popup_public_account_logout_button_border.png [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ui/views/animation/ink_drop_host_view.h [modify] https://crrev.com/184394b156baaeb9ea061711192b5a5cae697505/ui/views/controls/button/custom_button.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66c91e5046e5f7430e4f62593a1fe5d6dfe347de commit 66c91e5046e5f7430e4f62593a1fe5d6dfe347de Author: estade <estade@chromium.org> Date: Wed Feb 22 18:52:10 2017 Remove last MD reference from TrayPopupUtils. Remove NonMdSlider. Merge MdSlider and Slider. BUG= 686288 , 686215 Review-Url: https://codereview.chromium.org/2692043009 Cr-Commit-Position: refs/heads/master@{#452148} [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ash/common/system/tray/tray_constants.cc [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ash/common/system/tray/tray_constants.h [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ui/views/BUILD.gn [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/controls/md_slider.cc [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/controls/md_slider.h [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/controls/non_md_slider.cc [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/controls/non_md_slider.h [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ui/views/controls/slider.cc [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ui/views/controls/slider.h [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ui/views/controls/slider_unittest.cc [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ui/views/examples/slider_example.cc [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_center_active.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_center_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_center_pressed.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_left_active.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_left_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_left_pressed.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_right_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_right_pressed.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_thumb.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_100_percent/slider_thumb_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_center_active.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_center_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_center_pressed.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_left_active.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_left_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_left_pressed.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_right_disabled.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_right_pressed.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_thumb.png [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/resources/default_200_percent/slider_thumb_disabled.png [modify] https://crrev.com/66c91e5046e5f7430e4f62593a1fe5d6dfe347de/ui/views/resources/views_resources.grd [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/test/test_slider.cc [delete] https://crrev.com/661aefbaac632bfaccfdb91a48242817de30a500/ui/views/test/test_slider.h
Evan can this be marked Fixed for m-58 or should this be punted to m-59?
seems fixed
Comment 1 by tdander...@chromium.org
, Feb 7 2017