New issue
Advanced search Search tips

Issue 686286 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 690992



Sign in to add a comment

Clean up non-MD code for the IME detailed view and the opt-in IME menu

Project Member Reported by tdander...@chromium.org, Jan 27 2017

Issue description

Clean up non-MD code for the opt-in IME menu. Specifically, in the following two files:

* ash/common/system/chromeos/ime_menu/ime_list_view.cc
* ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Cleanup for the IME detailed and default views in the system menu will be handled in  issue 686284 .

 
Let's wait until M-56 has a bit of time to bake on stable channel before doing this.
Labels: Hotlist-CodeHealth
Blocking: 690992
Labels: -M-58 M-59

Comment 5 by est...@chromium.org, Mar 28 2017

Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

Summary: Clean up non-MD code for the IME detailed view and the opt-in IME menu (was: Clean up non-MD code for the opt-in IME menu)
Cc: azurewei@chromium.org
Remove remaining non-MD code from ImeListView and ImeListItemView: https://codereview.chromium.org/2793153004
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a

commit 9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a
Author: tdanderson <tdanderson@chromium.org>
Date: Wed Apr 05 21:43:33 2017

[Ash] Remove non-MD code from ImeListView and ImeListItemView

Remove the pre-material design code paths remaining
in ImeListView and ImeListItemView.

BUG= 686286 
TEST=manual

Review-Url: https://codereview.chromium.org/2793153004
Cr-Commit-Position: refs/heads/master@{#462228}

[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/ash_strings.grd
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_details_view.h

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97a28284f3b297f32f11bbd84c728c07024ae3af

commit 97a28284f3b297f32f11bbd84c728c07024ae3af
Author: tdanderson <tdanderson@chromium.org>
Date: Thu Apr 13 16:28:33 2017

[Ash] Use DCHECK in ImeListView::HandleButtonPressed()

Switch the order of calling up to the base class
from within ImeDetailedView::HandleButtonPressed(),
and switch the conditional to a DCHECK in
ImeListView::HandleButtonPressed(); this should be
called if and only if the corresponding toggle button
exists and is clicked.

BUG= 686286 
TEST=manual

Review-Url: https://codereview.chromium.org/2805733002
Cr-Commit-Position: refs/heads/master@{#464433}

[modify] https://crrev.com/97a28284f3b297f32f11bbd84c728c07024ae3af/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/97a28284f3b297f32f11bbd84c728c07024ae3af/ash/system/ime_menu/ime_list_view.cc

Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment