New issue
Advanced search Search tips

Issue 686286 link

Starred by 2 users
Status: Verified
Owner:
est...@chromium.org
Closed: Apr 2017
Cc:
azurewei@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 690992



Sign in to add a comment

Clean up non-MD code for the IME detailed view and the opt-in IME menu

Project Member Reported by tdander...@chromium.org, Jan 27 2017 
Clean up non-MD code for the opt-in IME menu. Specifically, in the following two files:

* ash/common/system/chromeos/ime_menu/ime_list_view.cc
* ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Cleanup for the IME detailed and default views in the system menu will be handled in  issue 686284 .

Comment 1 by tdander...@chromium.org, Jan 27 2017 

Let's wait until M-56 has a bit of time to bake on stable channel before doing this.

Comment 2 by tdander...@chromium.org, Feb 7 2017

Labels: Hotlist-CodeHealth

Comment 3 by tdander...@chromium.org, Feb 10 2017

Blocking: 690992

Comment 4 by tdander...@chromium.org, Mar 7 2017

Labels: -M-58 M-59

Comment 5 by est...@chromium.org, Mar 28 2017

Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a553b86b80c49a8e3d94774004b5c85ed09cf74a

commit a553b86b80c49a8e3d94774004b5c85ed09cf74a
Author: estade <estade@chromium.org>
Date: Wed Mar 29 19:04:55 2017

Remove non-MD code for IME tray and tray menu.

BUG= 686284 , 686286 

Review-Url: https://codereview.chromium.org/2781793002
Cr-Commit-Position: refs/heads/master@{#460477}

[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/a553b86b80c49a8e3d94774004b5c85ed09cf74a/ash/resources/ash_resources.grd
[delete] https://crrev.com/2cf99830cfbe5d462b161089bb159ac9f29a620c/ash/resources/default_100_percent/cros/status/status_ime.png
[delete] https://crrev.com/2cf99830cfbe5d462b161089bb159ac9f29a620c/ash/resources/default_200_percent/cros/status/status_ime.png

Comment 7 by tdander...@chromium.org, Apr 4 2017

Summary: Clean up non-MD code for the IME detailed view and the opt-in IME menu (was: Clean up non-MD code for the opt-in IME menu)

Comment 8 by tdander...@chromium.org, Apr 4 2017

Cc: azurewei@chromium.org
Remove remaining non-MD code from ImeListView and ImeListItemView: https://codereview.chromium.org/2793153004
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a

commit 9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a
Author: tdanderson <tdanderson@chromium.org>
Date: Wed Apr 05 21:43:33 2017

[Ash] Remove non-MD code from ImeListView and ImeListItemView

Remove the pre-material design code paths remaining
in ImeListView and ImeListItemView.

BUG= 686286 
TEST=manual

Review-Url: https://codereview.chromium.org/2793153004
Cr-Commit-Position: refs/heads/master@{#462228}

[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/ash_strings.grd
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/chromeos/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_constants.h
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/9e3fb2888342b8a8037c5b8288fd53dc6c30cf9a/ash/common/system/tray/tray_details_view.h

Comment 10 by tdander...@chromium.org, Apr 6 2017

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97a28284f3b297f32f11bbd84c728c07024ae3af

commit 97a28284f3b297f32f11bbd84c728c07024ae3af
Author: tdanderson <tdanderson@chromium.org>
Date: Thu Apr 13 16:28:33 2017

[Ash] Use DCHECK in ImeListView::HandleButtonPressed()

Switch the order of calling up to the base class
from within ImeDetailedView::HandleButtonPressed(),
and switch the conditional to a DCHECK in
ImeListView::HandleButtonPressed(); this should be
called if and only if the corresponding toggle button
exists and is clicked.

BUG= 686286 
TEST=manual

Review-Url: https://codereview.chromium.org/2805733002
Cr-Commit-Position: refs/heads/master@{#464433}

[modify] https://crrev.com/97a28284f3b297f32f11bbd84c728c07024ae3af/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/97a28284f3b297f32f11bbd84c728c07024ae3af/ash/system/ime_menu/ime_list_view.cc

Comment 12 by sdantul...@chromium.org, May 8 2017

Labels: code-change
Status: Verified (was: Fixed)
►

Sign in to add a comment