Ongoing automatic downloads snapshots should not cancel manual requests |
|||
Issue descriptionNote: this only applies once https://codereview.chromium.org/2655673005 lands. RecentTabHelper ignores overlapping download requests to snapshot a page. This stops the user from creating a overwhelming number of snapshot saves by continuously pressing the downloads button. It does also has an automatic trigger that allows the latest downloaded snapshot to be upgraded to a higher quality one if needed, once the page reaches what is considered "high" quality. For this to happen a downloads snapshot request is created silently. The edge case here is that if the user decides to request a snapshot to be saved precisely at the moment when this automatic request is being served, the users' one will be ignored without clear feedback. We have to make a decision on how to better handle this situation. A few options are: * To schedule the user's request to be executed later. * To stop automatically upgrading the latest saved downloads snapshot.
,
Feb 8 2017
,
Mar 1 2017
Note: https://codereview.chromium.org/2655673005 has landed. Fixit update: a decision has as explained in the OP as to how to handle this situation. Me and dimich@ are the minimum quorum to make that decision.
,
Mar 24 2017
After an offline discussion we decided to not work on this because: * We don't have user reports on this so it seems it's not really affecting users. * The edge case described here seems to be really rare. * Once we update SnapshotController (based off Right Moment Detection ongoing work) there will only be one snapshot trigger per page load. |
|||
►
Sign in to add a comment |
|||
Comment 1 by chili@chromium.org
, Feb 7 2017