New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686280 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Recipe engine bug: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 266764: ordinal not in range(128)

Project Member Reported by erikc...@chromium.org, Jan 27 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=686280

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg8K7XiQkM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 28 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:gpu_process:reported_by_chrome:malloc:effective_size_avg/blank_about

Suspected Commit Range
  70 commits in range
  https://chromium.googlesource.com/chromium/src/+log/b11b7e7c8ade6d7ac945e772dc5776b2fe663bf8..6330a84569f489d790559d0e238c5a42d4700358


Revision             Result                   N
chromium@445600      12438100 +- 4705485      9      good
chromium@445670      17368910 +- 8464979      9      bad
chromium@445739      17312869 +- 4493322      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests system_health.memory_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8989273408825666800

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5633756217475072


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: sullivan@chromium.org
sullivan: Could you help figure out why the bisect failed? When I follow the link, I arrived at:
https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_11_perf_bisect/builds/1189, where it says "Recipe engine bug". Clicking on stdio gives: "This site can’t be reached".
Use the logdog links.

This seems to be the error:

Traceback (most recent call last):
  File "/b/rr/tmpzK2AfT/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/util.py", line 150, in raises
    yield
  File "/b/rr/tmpzK2AfT/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/run.py", line 392, in run_step
    open_step = self._step_runner.open_step(step_config)
  File "/b/rr/tmpzK2AfT/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/step_runner.py", line 174, in open_step
    step_config, recipe_test_api.DisabledTestData()
  File "/b/rr/tmpzK2AfT/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/step_runner.py", line 524, in render_step
    new_cmd.extend(item.render(tdata))
  File "/b/rr/tmpzK2AfT/rw/checkout/scripts/slave/.recipe_deps/recipe_engine/recipe_modules/raw_io/api.py", line 33, in render
    os.write(input_fd, self.data.encode('utf-8'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 266764: ordinal not in range(128)
Components: Tests>Telemetry
Owner: simonhatch@chromium.org
Cc: benhenry@chromium.org
+benhenry

Do you know who can help look at this on infra's side?
Owner: d...@chromium.org
Status: Assigned (was: Untriaged)
hey Dan - could you or Robbie look at this issue? 

Comment 10 by d...@chromium.org, Jan 31 2017

Looks like your code is emitting non-ASCII text?
dnj@ those non-ASCII text may come from the chrome stack trace when the browser crashes.

Comment 12 by d...@chromium.org, Jan 31 2017

Owner: benhenry@chromium.org
Maybe? I don't really know.

I'm in the middle of a lot of other things right now, I don't have time to take point on this. Please find someone else or ... a trooper?
We also see a regression in ChromiumPerf/chromium-rel-mac11/system_health.memory_desktop / memory:chrome:all_processes:reported_by_os:resident_size_avg / blank_about / blank_about_blank

https://chromeperf.appspot.com/report?sid=f4685debfab1eac23ee94bc50a0cd22e4ff3d755b7e7d5c7a97f687bea26ed77

Looking at before/after traces, we also see a 8MB bump in GPU process total resident size:
https://00e9e64baceb43518ffdd651a494811c917c0d273ebca91f3e-apidata.googleusercontent.com/download/storage/v1/b/chrome-telemetry-output/o/trace-file-id_0-2017-01-24_02-32-43-1078.html?qk=AD5uMEvDnKZm12qOHhOFxsSZ3braRRlipz7GOnTv8X44mGwxrkllqd_FbGa1LMjOigWENY-JsUDk_elhWG65Ot8kogczn1lcFMSozR230cQyBPYL8-YJzxDblGM4llnUTdO4wcYMqNJdBmTIuZavR7-_1gnw849kvsRm5LGQupeYEWEaYSR7wLS-zxNTBU9Of2b8RYJ-fi5cYHlDn7zpOsry2bnKkGB0Tmz8sSITG63jG2papR4-HtVwnq6F-LgUubvHy7kIO3ytj3I6Zg0xVmbXYB3K5STJQ-_wt0jgJQVBKWhXc4GHIV4Y09M5Et6-nS8BVw7s_IKdoO3TpbappvCDNpfcEQrJ-WV81QzLYgsAJH86EnM2OxawuG8HbXn6tzUFtw4ikFmhIh6TrEPGla0h0wBLs62Y2Hhw9HDg7YJ89VGD9GRyV5JygTx_BsIcFURtu4OTcdzTD667BkUgudGbJy0yONIgPsdlj4jGaG-UzGT9lcxW9bAQqLgEL5ETcOCQxu-fO3FrhySMuEU34dsD3HmDN8p9DqS-jZglpTd9UKpWjz7r1INzQQVI2yZhdhIew7GVh7h3bu_D4TIoYpu0dvV3r3wG-FHqT7JX9gmCclsK3mjdRLU39Ac71DJ227dWXTVLxHGxyn253n8ObKVL4Wqd4UsBxGfk4yjOMRYFYTDpVzFbG6Gf5TkyHNtxbgyddfluP4ltJj0P4G72XP0OOh4m3TuolUmEx5bb-JSf2BL3-mNnEUwMHIQSPXCxDsZrR1vDMGk1zewsFBEefiYZHs5oYsaLLcfeuKiIBquuXXmulLAR6EEif7-q2-jeo0QSn26HKN3XKp0DhJ6tB53RLbJfjl-cBw

https://00e9e64bac2a6c859104c567b267605e12a548d7605e6fa06b-apidata.googleusercontent.com/download/storage/v1/b/chrome-telemetry-output/o/trace-file-id_0-2017-01-23_21-48-33-15377.html?qk=AD5uMEtXGsqzGu0YuDICZOmhTIGyWfE566dN6QSHGGBDyxHxm7JzZaCaxr_oeKzhp3zAd9yHHw2u8goZfkRr10k5wLaRc095M6qaT2Kg6BNkn-PXmwKj_lspkWUyE45m1QpGTu4TpxecwyPV5WLCxYbQ382pCozAEdGeXFrB37d1yV-3nFX-oXn-DJOZPh1lOzEi21bDG9NCjKbzJc9NZC6KEWZdL0r8FO9dC0K1RUekjD5liczMb8xydjKzYNtui8Mc5EHB3IYHWY2s1HYe4UC_6Xv7exYgaCGqXUydmGLf5d9a4-bxJO6fHoIrSPN2y_l4wj5zjxMN0nRSCJkr6UZgwaqHfGkT4gjR_o4J_EQg4fwmqkcFlk3klNPVQh7bFkJFx0icnuYWIB-z54q4jBcetXNan4K6EA4kxKuCRusAnldHPGOaFi2EvULbgrfdyoxau3R0U02Dx3uVhDADsRO4YcS0WFIsddSlBTuBaIoyYKtqLkPkHaR0YxjNytIIhiGiyYw7pOnxSh85vQ2uTrvJUPw4dBzJnauAbz9X1q3JUVnIbdcdL-NsWV8UfJnMTWDKWNjCJgq2Zy9RL8PcaIjXyYyjpOloP87DkkuKy669Zu8rw3KOh14Xv8awdoLheNSo5KALbsJPHDsi0T2ka4-QHTbSIr--_LWgSOhHaA_U7IYvwYaRBrDjCqMO6JDhpeDk7jtj8I9zSGt1rHkC8TeVk8flM03RJSid6V283bdsCUwavMKfHkv00DE2C5cfy-K2lJqpDMz42mbZLn9cnKQ6yQIV5zPTrasBYNyklW3HE53hcH65rXatRR95ZsAJzUg8ioKHlUbhKatQWZJhiCkv8w2QJX33zA
I've scheduled a bisect for that metric:
https://chromeperf.appspot.com/buildbucket_job_status/8988910892650803712

we'll see if that works better.
Labels: Infra-Troopers
Owner: ----
Status: Untriaged (was: Assigned)
Trooper to read comment #5 and comment #12.
Components: -Tests>Telemetry Infra>Platform>Recipes
Labels: -Infra-Troopers
Summary: Recipe engine bug: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 266764: ordinal not in range(128) (was: 33.8% regression in system_health.memory_desktop at 445601:445739)
It looks like it's happening here:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/bisect_tester/perf_test.py?q=%22write+buildbot+output+to+disk%22&sq=package:chromium&l=141

I'm guessing "out" is a unicode string and is not supported by file when writing out to disk?
Cc: iannucci@chromium.org
Owner: martiniss@chromium.org
Status: Started (was: Untriaged)
I'm working on a patch to fix this. It will force the default recipes raw_io calls to try to use utf-8 encoding, and it will replace any encoding or decoding errors. https://docs.python.org/2/library/codecs.html#codec-base-classes 'replace' option is what it's using.

Rollout of this patch is somewhat complicated. I'll try to make it happen this week.
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/0551f8679ed7d8935c0e4373e6ebea8435aeaacb

commit 0551f8679ed7d8935c0e4373e6ebea8435aeaacb
Author: Stephen Martinis <martiniss@google.com>
Date: Wed Feb 08 00:35:50 2017

Manual roll of raw_io output -> output_text refactor

BUG= 686280 ,664352
TBR=iannucci

Change-Id: Ibd1feadffc440ea01790abe2bc73fc6a69092f54
Reviewed-on: https://chromium-review.googlesource.com/437821
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/0551f8679ed7d8935c0e4373e6ebea8435aeaacb/infra/config/recipes.cfg
[modify] https://crrev.com/0551f8679ed7d8935c0e4373e6ebea8435aeaacb/recipe_modules/tryserver/example.py

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1

commit 4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1
Author: Stephen Martinis <martiniss@google.com>
Date: Wed Feb 08 00:45:02 2017

Manual roll of raw_io output -> output_text refactor

BUG= 686280 ,664352

Change-Id: I9513216fca4b3baf17016b940b9c0c8ee374c716
Reviewed-on: https://chromium-review.googlesource.com/437762
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/swarming/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/findit/chromium/update_components.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/goma/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/luci_config/test_api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/webrtc/auto_roll_webrtc_deps.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/legion/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/client.drmemory.recipe_autogen.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/findit/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/bisection/desktop_bisect.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/chromium_libfuzzer.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/buildbucket/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/chromium_android/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/infra/config/recipes.cfg
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/webrtc/ios.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/auto_bisect/revision_state.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/v8/auto_tag.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/v8/auto_roll_v8_deps.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/findit/chromium/preemptive_bot_update.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/ios/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/bisection/android_bisect.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/v8/auto_roll_deps.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/chromium_codesearch.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/skia/swarm_perf.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/repo/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/skia/swarm_trigger.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/skia/android_flavor.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/infra/gae_sdk_cipd_packager.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/service_account/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/bisection/desktop_bisect_staging.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/commit_position/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/skia/ios_flavor.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/chromium_afl.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/recipe_autoroller/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/chromedriver/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/url/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/v8/auto_roll_release_process.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/omahaproxy/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/auto_bisect_staging/revision_state.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/skia/swarm_infra.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/chromium_tests/steps.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/file/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/swarming_client/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/auto_bisect_staging/test_api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/skia/swarm_test.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/service_account/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/commit_position/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/ios/unified_builder_tester.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/chromium_android/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/buildbucket/test_api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/simple_ci.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/libvpx/android_unittests.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/bisect_tester/perf_test.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/v8/infra_end_to_end.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/bisect_tester_staging/perf_test.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/bisection/android_bisect_staging.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/findit/chromium/compile.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/auto_bisect/test_api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/skia_swarming/api.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipe_modules/swarming_client/example.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/ios/try.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/webrtc/libfuzzer.py
[modify] https://crrev.com/4b066e8e0f5c15db81a7df16b74cfb6bf54e13b1/scripts/slave/recipes/v8/auto_roll_push.py

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/1fe76b95ef84d97abecdb6d564d17c621f0fbfa5

commit 1fe76b95ef84d97abecdb6d564d17c621f0fbfa5
Author: Stephen Martinis <martiniss@google.com>
Date: Wed Feb 08 06:14:53 2017

Status: Fixed (was: Started)
Ok, this should have landed. Let me know if you see this happen again.

Sign in to add a comment