Issue 686270 link

Starred by 6 users

Issue metadata

Status:	Fixed
Owner:	tfarina@chromium.org
Closed:	Mar 2017
Components:	UI>Browser>Omnibox
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug

Remove assets for old omnibox chips etc.

Project Member Reported by pkasting@chromium.org, Jan 27 2017

Issue description

I believe all the following resources are dead, and should be removed along with their associated IDRs:

omnibox_content_setting_bubble_xxx.png
omnibox_ev_bubble_xxx.png
omnibox_popup_border_and_shadow_xxx.png
omnibox_selected_keyword_bubble_xxx.png

Comment 1 by pkasting@chromium.org, Feb 14 2017

Note, there are a bunch of other assets that may be dead too -- probably an audit of all .pngs is warranted

Comment 2 by tfarina@chromium.org, Feb 24 2017

Peter, can I send a patch for this? I don't know if there is already someone working on this.

Comment 3 by pkasting@chromium.org, Feb 24 2017

Feel free to send a patch.  Bonus points if you check the other .pngs and kill other dead ones too.

Comment 4 by tfarina@chromium.org, Mar 6 2017

Started on this. https://codereview.chromium.org/2732893002

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb8e0c0f6704de38561687fba89e02fdacf0cf9

commit 8bb8e0c0f6704de38561687fba89e02fdacf0cf9
Author: tfarina <tfarina@chromium.org>
Date: Mon Mar 06 22:10:32 2017

chrome: remove omnibox_content_setting_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG= 686270 
R=pkasting@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2732893002
Cr-Commit-Position: refs/heads/master@{#454971}

[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_bottom.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_bottom_left.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_bottom_right.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_center.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_left.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_right.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_top.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_top_left.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_100_percent/common/omnibox_content_setting_bubble_top_right.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_bottom.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_bottom_left.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_bottom_right.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_center.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_left.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_right.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_top.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_top_left.png
[delete] https://crrev.com/2f95f5ddf8ef97c73febf4237e2ee34128f9ec29/chrome/app/theme/default_200_percent/common/omnibox_content_setting_bubble_top_right.png
[modify] https://crrev.com/8bb8e0c0f6704de38561687fba89e02fdacf0cf9/chrome/app/theme/theme_resources.grd

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d0fedea76764c9132e6d19ec8679880339a8eef

commit 9d0fedea76764c9132e6d19ec8679880339a8eef
Author: tfarina <tfarina@chromium.org>
Date: Thu Mar 09 00:15:31 2017

chrome: remove omnibox_ev_bubble_xxx.png and omnibox_selected_keyword_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG= 686270 
R=pkasting@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2734063002
Cr-Commit-Position: refs/heads/master@{#455605}

[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_bottom.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_bottom_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_bottom_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_center.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_top.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_top_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_ev_bubble_top_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_bottom.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_bottom_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_bottom_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_center.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_top.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_top_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_100_percent/common/omnibox_selected_keyword_bubble_top_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_bottom.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_bottom_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_bottom_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_center.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_top.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_top_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_ev_bubble_top_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_bottom.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_bottom_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_bottom_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_center.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_right.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_top.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_top_left.png
[delete] https://crrev.com/3d4ced0b8d7081318da910aff495ed4f5f38f63e/chrome/app/theme/default_200_percent/common/omnibox_selected_keyword_bubble_top_right.png
[modify] https://crrev.com/9d0fedea76764c9132e6d19ec8679880339a8eef/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/9d0fedea76764c9132e6d19ec8679880339a8eef/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/9d0fedea76764c9132e6d19ec8679880339a8eef/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h
[modify] https://crrev.com/9d0fedea76764c9132e6d19ec8679880339a8eef/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
[modify] https://crrev.com/9d0fedea76764c9132e6d19ec8679880339a8eef/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h
[modify] https://crrev.com/9d0fedea76764c9132e6d19ec8679880339a8eef/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdef30a5605a2ad16b9231033887ce2307156e62

commit bdef30a5605a2ad16b9231033887ce2307156e62
Author: tfarina <tfarina@chromium.org>
Date: Thu Mar 09 21:35:20 2017

chrome: remove omnibox_popup_border_and_shadow_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG= 686270 
R=pkasting@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2741603003
Cr-Commit-Position: refs/heads/master@{#455868}

[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_bottom.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_bottom_left.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_bottom_right.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_center.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_left.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_right.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_top.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_top_left.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_100_percent/common/omnibox_popup_border_and_shadow_top_right.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_bottom.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_bottom_left.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_bottom_right.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_center.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_left.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_right.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_top.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_top_left.png
[delete] https://crrev.com/dc4cda062ada67cd3c845149d58a4dc7545a00c1/chrome/app/theme/default_200_percent/common/omnibox_popup_border_and_shadow_top_right.png
[modify] https://crrev.com/bdef30a5605a2ad16b9231033887ce2307156e62/chrome/app/theme/theme_resources.grd

Comment 8 by tfarina@chromium.org, Mar 9 2017

Looks like we have https://cs.chromium.org/chromium/src/tools/resources/find_unused_resources.py?dr to help here to find the other unused assets.

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2376acd53cf462a35e9330fe298590d02ea084f9

commit 2376acd53cf462a35e9330fe298590d02ea084f9
Author: tfarina <tfarina@chromium.org>
Date: Mon Mar 13 23:00:46 2017

chrome: remove unused assets

Remove unused assets along with their associate IDRs.

BUG= 686270 
R=pkasting@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2743543005
Cr-Commit-Position: refs/heads/master@{#456523}

[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/allowed_fullscreen.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/allowed_mouse_cursor.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/blocked_mouse_cursor.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/close_1_mask.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_bottom.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_bottom_left.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_bottom_right.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_center.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_left.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_right.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_top.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_top_left.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_top_right.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/cros/limited_user.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/avatar_menu_child.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/avatar_menu_legacy_supervised.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/avatar_menu_lock.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/chevron.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/icon_legacy_supervised.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/keyword_search_magnifier.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/tab_audio_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/tab_audio_muting_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/tab_bluetooth_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/tab_capture_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/tab_usb_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/translate_active.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/zoom_minus.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/zoom_plus.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_100_percent/legacy/zoom_reset.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/allowed_fullscreen.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/allowed_mouse_cursor.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/blocked_mouse_cursor.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/close_1_mask.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_bottom.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_bottom_left.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_bottom_right.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_center.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_left.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_right.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_top.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_top_left.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_top_right.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/cros/limited_user.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/avatar_menu_child.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/avatar_menu_legacy_supervised.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/avatar_menu_lock.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/chevron.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/icon_legacy_supervised.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/keyword_search_magnifier.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/tab_audio_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/tab_audio_muting_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/tab_bluetooth_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/tab_capture_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/tab_usb_indicator.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/translate_active.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/zoom_minus.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/zoom_plus.png
[delete] https://crrev.com/35940a6d7e30f4aa3de61eb5dc6a3caace1a1482/chrome/app/theme/default_200_percent/legacy/zoom_reset.png
[modify] https://crrev.com/2376acd53cf462a35e9330fe298590d02ea084f9/chrome/app/theme/theme_resources.grd

Comment 10 by tfarina@chromium.org, Mar 14 2017

Owner: tfarina@chromium.org
Status: Fixed (was: Assigned)

Comment 11 by pkasting@chromium.org, Mar 14 2017

Rad!

So I know whether anything remains to be done here, did you end up checking all the .pngs in the product?  All the .pngs in chrome/app/theme/?  All the .pngs referenced by the location bar classes?  Want to know what the scope of audit was.

Comment 12 by tfarina@chromium.org, Mar 14 2017

Everything referenced in theme_resources.grd.

►

Issue 686270 link

Issue metadata

Remove assets for old omnibox chips etc.

Issue description

Comment 1 by pkasting@chromium.org, Feb 14 2017

Comment 1 Deleted

Comment 2 by tfarina@chromium.org, Feb 24 2017

Comment 2 Deleted

Comment 3 by pkasting@chromium.org, Feb 24 2017

Comment 3 Deleted

Comment 4 by tfarina@chromium.org, Mar 6 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Mar 6 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Mar 9 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Mar 9 2017

Comment 7 Deleted

Comment 8 by tfarina@chromium.org, Mar 9 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Mar 13 2017

Comment 9 Deleted

Comment 10 by tfarina@chromium.org, Mar 14 2017

Comment 10 Deleted

Comment 11 by pkasting@chromium.org, Mar 14 2017

Comment 11 Deleted

Comment 12 by tfarina@chromium.org, Mar 14 2017

Comment 12 Deleted

Sign in to add a comment