New issue
Advanced search Search tips

Issue 686261 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 686251
issue 686256
issue 686258



Sign in to add a comment

Remove unused TrayPopupLabelButton class

Project Member Reported by tdander...@chromium.org, Jan 27 2017

Issue description

Remove the unused TrayPopupLabelButton class once all references to it have been removed (see blockers).

 
Labels: Hotlist-CodeHealth
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62ff72d4604ce4bb6f7f612d8ca02436e098695e

commit 62ff72d4604ce4bb6f7f612d8ca02436e098695e
Author: estade <estade@chromium.org>
Date: Wed Feb 08 02:52:51 2017

Remove TrayPopupLabelButton (a pre-MD class) and its assets.

This also tears out some pre-MD code from other files, but I tried to
limit that to the minimum required to remove this button class.

BUG= 686261 , 686251 

Review-Url: https://codereview.chromium.org/2686703002
Cr-Commit-Position: refs/heads/master@{#448876}

[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/BUILD.gn
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/network_state_list_detailed_view.h
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/screen_security/screen_tray_item.h
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button.cc
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button.h
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button_border.cc
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button_border.h
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/user/user_view.cc
[modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/resources/ash_resources.grd
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_100_percent/common/tray_popup_label_button_border.png
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_100_percent/common/tray_popup_label_button_hover_background.png
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_100_percent/common/tray_popup_label_button_normal_background.png
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_200_percent/common/tray_popup_label_button_border.png
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_200_percent/common/tray_popup_label_button_hover_background.png
[delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_200_percent/common/tray_popup_label_button_normal_background.png

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment