New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686256 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 686261



Sign in to add a comment

Clean up of non-MD accessibility UI code paths in the Ash system menu

Project Member Reported by tdander...@chromium.org, Jan 27 2017

Issue description

Clean up of non-MD accessibility UI code paths in the Ash system menu, including:

* AccessibilityDetailedView
* DefaultAccessibilityView
* Elsewhere in tray_accessibility.cc.

 
Blocking: 686261
Labels: Hotlist-CodeHealth
Status: Started (was: Assigned)
https://codereview.chromium.org/2700653002/
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf

commit d76a3c6165fa6b8d279372c7c4cd5f383d63cecf
Author: tdanderson <tdanderson@chromium.org>
Date: Fri Feb 17 22:53:10 2017

[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG= 686217 , 686256 , 687813 , 687814 , 687815 , 687818 
TEST=manual, no functional changes

Review-Url: https://codereview.chromium.org/2700653002
Cr-Commit-Position: refs/heads/master@{#451392}

[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/chromeos/audio/tray_audio.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/tray/tray_image_item.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/tray/tray_image_item.h
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/resources/ash_resources.grd
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_accessibility_mode.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_auto_rotate_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_auto_rotate_locked.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_auto_rotate_locked_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_capslock.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_capslock_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_tracing.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_volume_mute.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_accessibility_mode.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_auto_rotate_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_auto_rotate_locked.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_auto_rotate_locked_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_capslock.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_capslock_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_tracing.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_volume_mute.png
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/system/chromeos/rotation/tray_rotation_lock.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d92113de572fd2b76fb9185a715833fd79b896f7

commit d92113de572fd2b76fb9185a715833fd79b896f7
Author: tdanderson <tdanderson@chromium.org>
Date: Wed Feb 22 22:05:59 2017

Remove remaining non-MD Ash accessibility UI code

Remove the remaining non-MD code paths for
accessibility in the Ash system menu.

BUG= 686256 

Review-Url: https://codereview.chromium.org/2707323003
Cr-Commit-Position: refs/heads/master@{#452225}

[modify] https://crrev.com/d92113de572fd2b76fb9185a715833fd79b896f7/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/d92113de572fd2b76fb9185a715833fd79b896f7/ash/common/system/tray_accessibility.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment