Clean up the non-MD code paths in ash/common/system/chromeos/network/network_state_list_detailed_view.cc and also remove the unused NetworkListView class.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62ff72d4604ce4bb6f7f612d8ca02436e098695e commit 62ff72d4604ce4bb6f7f612d8ca02436e098695e Author: estade <estade@chromium.org> Date: Wed Feb 08 02:52:51 2017 Remove TrayPopupLabelButton (a pre-MD class) and its assets. This also tears out some pre-MD code from other files, but I tried to limit that to the minimum required to remove this button class. BUG= 686261 , 686251 Review-Url: https://codereview.chromium.org/2686703002 Cr-Commit-Position: refs/heads/master@{#448876} [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/BUILD.gn [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/network_state_list_detailed_view.cc [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/network_state_list_detailed_view.h [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/tray_vpn.cc [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/network/vpn_list_view.cc [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/chromeos/screen_security/screen_tray_item.h [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button.cc [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button.h [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button_border.cc [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/common/system/tray/tray_popup_label_button_border.h [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/tray/tray_popup_utils.cc [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/tray_accessibility.cc [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/common/system/user/user_view.cc [modify] https://crrev.com/62ff72d4604ce4bb6f7f612d8ca02436e098695e/ash/resources/ash_resources.grd [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_100_percent/common/tray_popup_label_button_border.png [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_100_percent/common/tray_popup_label_button_hover_background.png [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_100_percent/common/tray_popup_label_button_normal_background.png [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_200_percent/common/tray_popup_label_button_border.png [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_200_percent/common/tray_popup_label_button_hover_background.png [delete] https://crrev.com/29810350d256c855e8d1af4c715b28da3a992336/ash/resources/default_200_percent/common/tray_popup_label_button_normal_background.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e65c53ffdbcab7f2d25f064a3a7540166101e54 commit 1e65c53ffdbcab7f2d25f064a3a7540166101e54 Author: estade <estade@chromium.org> Date: Wed Mar 08 22:00:11 2017 Remove a lot of pre-MD code from NetworkStateListDetailedView BUG= 686251 Review-Url: https://codereview.chromium.org/2723863004 Cr-Commit-Position: refs/heads/master@{#455552} [modify] https://crrev.com/1e65c53ffdbcab7f2d25f064a3a7540166101e54/ash/BUILD.gn [delete] https://crrev.com/e23907eaba82f5595b74fb0094968481d6e00514/ash/common/system/chromeos/network/network_list.cc [delete] https://crrev.com/e23907eaba82f5595b74fb0094968481d6e00514/ash/common/system/chromeos/network/network_list.h [modify] https://crrev.com/1e65c53ffdbcab7f2d25f064a3a7540166101e54/ash/common/system/chromeos/network/network_list_md.cc [modify] https://crrev.com/1e65c53ffdbcab7f2d25f064a3a7540166101e54/ash/common/system/chromeos/network/network_list_md.h [modify] https://crrev.com/1e65c53ffdbcab7f2d25f064a3a7540166101e54/ash/common/system/chromeos/network/network_state_list_detailed_view.cc [modify] https://crrev.com/1e65c53ffdbcab7f2d25f064a3a7540166101e54/ash/common/system/chromeos/network/network_state_list_detailed_view.h [modify] https://crrev.com/1e65c53ffdbcab7f2d25f064a3a7540166101e54/ash/resources/ash_resources.grd [delete] https://crrev.com/e23907eaba82f5595b74fb0094968481d6e00514/ash/resources/default_100_percent/cros/network/status_network_info.png [delete] https://crrev.com/e23907eaba82f5595b74fb0094968481d6e00514/ash/resources/default_100_percent/cros/network/status_network_info_hover.png [delete] https://crrev.com/e23907eaba82f5595b74fb0094968481d6e00514/ash/resources/default_200_percent/cros/network/status_network_info.png [delete] https://crrev.com/e23907eaba82f5595b74fb0094968481d6e00514/ash/resources/default_200_percent/cros/network/status_network_info_hover.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35 commit 9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35 Author: xhwang <xhwang@chromium.org> Date: Wed Mar 08 22:25:24 2017 Revert of Remove a lot of pre-MD code from NetworkStateListDetailedView (patchset #7 id:110001 of https://codereview.chromium.org/2723863004/ ) Reason for revert: This is breaking Google Chrome ChromeOS bot: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/30458 Original issue's description: > Remove a lot of pre-MD code from NetworkStateListDetailedView > > BUG= 686251 > > Review-Url: https://codereview.chromium.org/2723863004 > Cr-Commit-Position: refs/heads/master@{#455552} > Committed: https://chromium.googlesource.com/chromium/src/+/1e65c53ffdbcab7f2d25f064a3a7540166101e54 TBR=tdanderson@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 686251 Review-Url: https://codereview.chromium.org/2742513003 Cr-Commit-Position: refs/heads/master@{#455556} [modify] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/BUILD.gn [add] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/common/system/chromeos/network/network_list.cc [add] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/common/system/chromeos/network/network_list.h [modify] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/common/system/chromeos/network/network_list_md.cc [modify] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/common/system/chromeos/network/network_list_md.h [modify] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/common/system/chromeos/network/network_state_list_detailed_view.cc [modify] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/common/system/chromeos/network/network_state_list_detailed_view.h [modify] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/resources/ash_resources.grd [add] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/resources/default_100_percent/cros/network/status_network_info.png [add] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/resources/default_100_percent/cros/network/status_network_info_hover.png [add] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/resources/default_200_percent/cros/network/status_network_info.png [add] https://crrev.com/9d6d1bab117b08c8aa134f09f20d70c7d1eb3d35/ash/resources/default_200_percent/cros/network/status_network_info_hover.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5691fadbe2869c29e3983ceb3385bbff576c3cc commit d5691fadbe2869c29e3983ceb3385bbff576c3cc Author: estade <estade@chromium.org> Date: Thu Mar 09 04:08:48 2017 Reland 1e65c53ffdbcab7f2d25f064a3a7540166101e54 with fix for bad merge. Remove a lot of pre-MD code from NetworkStateListDetailedView BUG= 686251 TBR=tdanderson@chromium.org Review-Url: https://codereview.chromium.org/2737353002 Cr-Commit-Position: refs/heads/master@{#455663} [modify] https://crrev.com/d5691fadbe2869c29e3983ceb3385bbff576c3cc/ash/BUILD.gn [delete] https://crrev.com/af461a2d3b3a487c28cec7c5392da1d26df81f97/ash/common/system/chromeos/network/network_list.cc [delete] https://crrev.com/af461a2d3b3a487c28cec7c5392da1d26df81f97/ash/common/system/chromeos/network/network_list.h [modify] https://crrev.com/d5691fadbe2869c29e3983ceb3385bbff576c3cc/ash/common/system/chromeos/network/network_list_md.cc [modify] https://crrev.com/d5691fadbe2869c29e3983ceb3385bbff576c3cc/ash/common/system/chromeos/network/network_list_md.h [modify] https://crrev.com/d5691fadbe2869c29e3983ceb3385bbff576c3cc/ash/common/system/chromeos/network/network_state_list_detailed_view.cc [modify] https://crrev.com/d5691fadbe2869c29e3983ceb3385bbff576c3cc/ash/common/system/chromeos/network/network_state_list_detailed_view.h [modify] https://crrev.com/d5691fadbe2869c29e3983ceb3385bbff576c3cc/ash/resources/ash_resources.grd [delete] https://crrev.com/af461a2d3b3a487c28cec7c5392da1d26df81f97/ash/resources/default_100_percent/cros/network/status_network_info.png [delete] https://crrev.com/af461a2d3b3a487c28cec7c5392da1d26df81f97/ash/resources/default_100_percent/cros/network/status_network_info_hover.png [delete] https://crrev.com/af461a2d3b3a487c28cec7c5392da1d26df81f97/ash/resources/default_200_percent/cros/network/status_network_info.png [delete] https://crrev.com/af461a2d3b3a487c28cec7c5392da1d26df81f97/ash/resources/default_200_percent/cros/network/status_network_info_hover.png
note to self: still have to rename network_list_md.*
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784 commit aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784 Author: estade <estade@chromium.org> Date: Tue Apr 04 02:17:30 2017 Minor pre-MD cleanups in chromeos network UI code (just renames). BUG= 686251 Review-Url: https://codereview.chromium.org/2796693002 Cr-Commit-Position: refs/heads/master@{#461614} [modify] https://crrev.com/aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784/ash/BUILD.gn [rename] https://crrev.com/aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784/ash/common/system/chromeos/network/network_list.cc [rename] https://crrev.com/aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784/ash/common/system/chromeos/network/network_list.h [modify] https://crrev.com/aa1c0022137ae8c92a1c5dc786c1f0d3ab3a5784/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
Comment 1 by tdander...@chromium.org
, Jan 27 2017