Remove all non-MD code paths from tray_bluetooth.cc, and make the MD code default.
Let's wait until M-56 has had a bit of time to bake in stable channel before doing this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb5795e85545bbf19fe0e1cd2000fecb3650b3ad commit eb5795e85545bbf19fe0e1cd2000fecb3650b3ad Author: fukino <fukino@chromium.org> Date: Mon Feb 13 21:19:16 2017 Remove non-MD code from Bluetooth tray. BUG= 686249 Review-Url: https://codereview.chromium.org/2684293002 Cr-Commit-Position: refs/heads/master@{#450090} [modify] https://crrev.com/eb5795e85545bbf19fe0e1cd2000fecb3650b3ad/ash/ash_strings.grd [modify] https://crrev.com/eb5795e85545bbf19fe0e1cd2000fecb3650b3ad/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc [modify] https://crrev.com/eb5795e85545bbf19fe0e1cd2000fecb3650b3ad/ash/resources/ash_resources.grd [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_100_percent/cros/status/status_bluetooth.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_100_percent/cros/status/status_bluetooth_disabled.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_100_percent/cros/status/status_bluetooth_disabled_hover.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_100_percent/cros/status/status_bluetooth_enabled.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_100_percent/cros/status/status_bluetooth_enabled_hover.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_200_percent/cros/status/status_bluetooth.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_200_percent/cros/status/status_bluetooth_disabled.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_200_percent/cros/status/status_bluetooth_disabled_hover.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_200_percent/cros/status/status_bluetooth_enabled.png [delete] https://crrev.com/43b1225755424b08683d7da6b99f8a695c6c86b4/ash/resources/default_200_percent/cros/status/status_bluetooth_enabled_hover.png
Hi, on ChromeOS, the Bluetooth settings UI doesn't work correctly. If click toggle button to turn on Bluetooth or click the settings button, the NOTREACHED() is called and causes crash: https://cs.chromium.org/chromium/src/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc?l=458
Re-opening this bug. fukino@, can you check to see if your recent cleanup could have been responsible for the crash mentioned in #6? juncai@, can you clarify which device, channel, and chrome version you are using?
I'll look into this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee70c9cdc585a45d3ba60b6dfcc74e79e99aab70 commit ee70c9cdc585a45d3ba60b6dfcc74e79e99aab70 Author: fukino <fukino@chromium.org> Date: Thu Feb 16 11:59:49 2017 Fix the crash on clicking buttons in Bluetooth system menu in debug build. In https://codereview.chromium.org/2684293002, 'else' before NOTREACHED() was accidentally dropped. It caused the crash on debug build. BUG= 686249 TBR=tdanderson@chromium.org TEST=click the toggle button and settings button in debug build. Review-Url: https://codereview.chromium.org/2698833003 Cr-Commit-Position: refs/heads/master@{#450936} [modify] https://crrev.com/ee70c9cdc585a45d3ba60b6dfcc74e79e99aab70/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
Hi, tdanderson@, sorry that I didn't see the comment earlier. I just built Chrome from master branch and ran it and saw the crash.
Thanks juncai@ for the report. It's fixed on ToT.
No problem. Thanks fukino@ for the fix.
ChromeOs:9304.0.0/Chrome:58.0.3015.0
Comment 1 by tdander...@chromium.org
, Jan 27 2017