New issue
Advanced search Search tips

Issue 686242 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 686254



Sign in to add a comment

Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime

Project Member Reported by rtoy@chromium.org, Jan 27 2017

Issue description

Chrome mistakenly implemented cancelAndHoldAtTime as cancelValuesAndHoldAtTime.

Use the correct name.
 

Comment 1 by rtoy@chromium.org, Jan 27 2017

Blocking: 686254
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5e8986bdcd359c7ca82d83907c81642dd01f55e

commit f5e8986bdcd359c7ca82d83907c81642dd01f55e
Author: rtoy <rtoy@chromium.org>
Date: Tue Jan 31 18:47:12 2017

Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime.

The actual automation name is cancelAndHoldAtTime, not
cancelValuesAndHoldAtTime:
https://webaudio.github.io/web-audio-api/#widl-AudioParam-cancelAndHoldAtTime-AudioParam-double-cancelTime

Make it so.

BUG= 686242 
TEST=AudioParam/audioparam-cancel-and-hold.html

Review-Url: https://codereview.chromium.org/2655073009
Cr-Commit-Position: refs/heads/master@{#447281}

[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/Source/modules/webaudio/AudioParam.idl
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/f5e8986bdcd359c7ca82d83907c81642dd01f55e/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Comment 3 by rtoy@chromium.org, Feb 1 2017

Labels: Merge-Request-57
cancelValuesAndHoldAtTime landed just before M57 branch.  Requesting merge to M57 to fix the incorrect name.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 1 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 1 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47fae361fff4ae9f22e1232b197074140e51d90c

commit 47fae361fff4ae9f22e1232b197074140e51d90c
Author: Raymond Toy <rtoy@chromium.org>
Date: Wed Feb 01 21:32:44 2017

Rename cancelValuesAndHoldAtTime to cancelAndHoldAtTime.

The actual automation name is cancelAndHoldAtTime, not
cancelValuesAndHoldAtTime:
https://webaudio.github.io/web-audio-api/#widl-AudioParam-cancelAndHoldAtTime-AudioParam-double-cancelTime

Make it so.

BUG= 686242 
TEST=AudioParam/audioparam-cancel-and-hold.html

Review-Url: https://codereview.chromium.org/2655073009
Cr-Commit-Position: refs/heads/master@{#447281}
(cherry picked from commit f5e8986bdcd359c7ca82d83907c81642dd01f55e)

Review-Url: https://codereview.chromium.org/2669663004 .
Cr-Commit-Position: refs/branch-heads/2987@{#253}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/Source/modules/webaudio/AudioParam.idl
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/47fae361fff4ae9f22e1232b197074140e51d90c/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.h

Comment 6 by rtoy@chromium.org, Feb 2 2017

Status: Fixed (was: Started)

Sign in to add a comment