New issue
Advanced search Search tips

Issue 686235 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make --use-mus-in-renderer the default for --mash

Project Member Reported by sadrul@chromium.org, Jan 27 2017

Issue description

When chrome runs in --mash, the renderer should default to run as a mus-client. This bug tracks making that default mode, and removing the code no longer needed when it's the only option for --mash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8185d9772224f42c18c942e8932441fe3ec025d7

commit 8185d9772224f42c18c942e8932441fe3ec025d7
Author: sadrul <sadrul@chromium.org>
Date: Tue Jan 31 18:30:11 2017

mus: Make --use-mus-in-renderer the default for --mash.

In mus, we want the renderer to be a mus client. So Make that the
default option. Keep an escape hatch --no-use-mus-in-renderer for a
few days before we remove the alternate option.

BUG= 686235 

Review-Url: https://codereview.chromium.org/2664963002
Cr-Commit-Position: refs/heads/master@{#447275}

[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/browser/browser_main_loop.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/public/common/content_switches.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/public/common/content_switches.h
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/renderer/mus/renderer_window_tree_client.h
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/renderer/render_widget.cc
[modify] https://crrev.com/8185d9772224f42c18c942e8932441fe3ec025d7/content/renderer/render_widget_unittest.cc

Can we close this now?
I am using this to track removal of unnecessary code too (see op)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be523b7cc0438b8bb9629c5863e1959a1e9fa272

commit be523b7cc0438b8bb9629c5863e1959a1e9fa272
Author: sadrul <sadrul@chromium.org>
Date: Mon Feb 06 19:35:24 2017

mus: Fix creating the factory for window-tree-client in renderer.

When a new tab is created, the browser first sends the request for the
window tree client to be created, and then requests the creation of
a RenderWidget. However, the renderer can also create a RenderWidget
and notify the browser, which then asks for the window tree client to
be created. So allow the window tree client to be created correctly
for a RenderWidget in both of these cases.

TBR=jam@ render_widget.cc since trivial rename of a function
BUG= 686235 

Review-Url: https://codereview.chromium.org/2676553003
Cr-Commit-Position: refs/heads/master@{#448351}

[modify] https://crrev.com/be523b7cc0438b8bb9629c5863e1959a1e9fa272/content/renderer/mus/render_widget_window_tree_client_factory.cc
[modify] https://crrev.com/be523b7cc0438b8bb9629c5863e1959a1e9fa272/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/be523b7cc0438b8bb9629c5863e1959a1e9fa272/content/renderer/mus/renderer_window_tree_client.h
[modify] https://crrev.com/be523b7cc0438b8bb9629c5863e1959a1e9fa272/content/renderer/render_widget.cc

Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment