Clean up non-MD code paths in the SystemTray class, and at the same time remove the now-unused TrayDate class.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c commit 36cfbe932ed734d1935b8eeb9273aff1b80c598c Author: estade <estade@chromium.org> Date: Mon Mar 27 18:33:02 2017 Remove some pre-md code and assets. BUG= 687816 , 686234 , 686335 Review-Url: https://codereview.chromium.org/2770953003 Cr-Commit-Position: refs/heads/master@{#459837} [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/BUILD.gn [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/power/power_status.cc [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/power/power_status.h [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/power/power_status_unittest.cc [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/chromeos/session/tray_session_length_limit.cc [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/common/system/chromeos/settings/tray_settings.cc [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/common/system/chromeos/settings/tray_settings.h [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/36cfbe932ed734d1935b8eeb9273aff1b80c598c/ash/resources/ash_resources.grd [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_brightness.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_100_percent/cros/status/status_settings.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_brightness.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png [delete] https://crrev.com/3321d7f0ab6782ed8e316e5b94b21aad2c77a603/ash/resources/default_200_percent/cros/status/status_settings.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd95e0083676d5e1b82a3bad0c2ccef61b557230 commit cd95e0083676d5e1b82a3bad0c2ccef61b557230 Author: jwd <jwd@chromium.org> Date: Mon Mar 27 21:30:57 2017 Revert of Remove some pre-md code and assets. (patchset #3 id:40001 of https://codereview.chromium.org/2770953003/ ) Reason for revert: Causing failures on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1) BUG= 705678 Original issue's description: > Remove some pre-md code and assets. > > BUG= 687816 , 686234 , 686335 > > Review-Url: https://codereview.chromium.org/2770953003 > Cr-Commit-Position: refs/heads/master@{#459837} > Committed: https://chromium.googlesource.com/chromium/src/+/36cfbe932ed734d1935b8eeb9273aff1b80c598c TBR=tdanderson@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 687816 , 686234 , 686335 Review-Url: https://codereview.chromium.org/2776973005 Cr-Commit-Position: refs/heads/master@{#459887} [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/BUILD.gn [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/power/power_status.cc [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/power/power_status.h [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/power/power_status_unittest.cc [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/session/tray_session_length_limit.cc [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/settings/tray_settings.cc [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/chromeos/settings/tray_settings.h [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/ash_resources.grd [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_brightness.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_100_percent/cros/status/status_settings.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_brightness.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png [add] https://crrev.com/cd95e0083676d5e1b82a3bad0c2ccef61b557230/ash/resources/default_200_percent/cros/status/status_settings.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8 commit 6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8 Author: estade <estade@chromium.org> Date: Tue Mar 28 03:16:13 2017 retry cd95e0083676d5e: Remove some pre-md code and assets. BUG= 687816 , 686234 , 686335 TBR=tdanderson@chromium.org Review-Url: https://codereview.chromium.org/2783503002 Cr-Commit-Position: refs/heads/master@{#459991} [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/BUILD.gn [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/brightness/tray_brightness.cc [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/power/power_status.cc [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/power/power_status.h [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/power/power_status_unittest.cc [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/chromeos/session/tray_session_length_limit.cc [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/common/system/chromeos/settings/tray_settings.cc [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/common/system/chromeos/settings/tray_settings.h [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/6d2bd8f3b6bd8c3911eaa31ef45e3cd827db55d8/ash/resources/ash_resources.grd [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/notification/notification_session_length_timer.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_brightness.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all_dark.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all_dark_fluctuating.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_power_small_all_fluctuating.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_100_percent/cros/status/status_settings.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/notification/notification_session_length_timer.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_brightness.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all_dark.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all_dark_fluctuating.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_power_small_all_fluctuating.png [delete] https://crrev.com/2e9d4aa2ac7d25f0769e8a9a3b88239fc53480f5/ash/resources/default_200_percent/cros/status/status_settings.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c921567339528ecf4dd25e5c68ef756d3ce17052 commit c921567339528ecf4dd25e5c68ef756d3ce17052 Author: estade <estade@chromium.org> Date: Tue Mar 28 23:07:33 2017 More pre-MD cleanup Remove TrayDate (unused in MD) Remove non-MD code from TimeView Remove assets Remove non-MD code from SystemTray BUG= 687804 , 686234 Review-Url: https://codereview.chromium.org/2778143002 Cr-Commit-Position: refs/heads/master@{#460232} [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/BUILD.gn [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/date_default_view.cc [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/date_default_view.h [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/date/date_view.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/date/date_view.h [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/tray_date.cc [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/common/system/date/tray_date.h [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/default_system_tray_delegate.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/default_system_tray_delegate.h [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray.h [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray_delegate.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/common/system/tray/system_tray_delegate.h [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/ash/resources/ash_resources.grd [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_help.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_help_hover.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_lockscreen.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_lockscreen_hover.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_shutdown.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_100_percent/cros/status/status_shutdown_hover.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_help.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_help_hover.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_lockscreen.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_lockscreen_hover.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_shutdown.png [delete] https://crrev.com/101693fbde07f4673dfc1e37ded32f9cb0f00c37/ash/resources/default_200_percent/cros/status/status_shutdown_hover.png [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/app/resources/locale_settings.grd [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/ui/ash/system_tray_delegate_chromeos.h [modify] https://crrev.com/c921567339528ecf4dd25e5c68ef756d3ce17052/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
Comment 1 by tdander...@chromium.org
, Feb 7 2017