Remove the code paths and PNG assets related to network and VPN state. Relevant areas of code include: ash/common/system/chromeos/network/network_icon.cc VpnDefaultView
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7f0828e30d63a0c2c5a7113237af8ecb41cfca8 commit e7f0828e30d63a0c2c5a7113237af8ecb41cfca8 Author: estade <estade@chromium.org> Date: Thu Feb 09 18:36:16 2017 Remove pre-MD code/assets for network iconography. BUG= 686233 Review-Url: https://codereview.chromium.org/2682683005 Cr-Commit-Position: refs/heads/master@{#449358} [modify] https://crrev.com/e7f0828e30d63a0c2c5a7113237af8ecb41cfca8/ash/common/system/chromeos/network/network_icon.cc [modify] https://crrev.com/e7f0828e30d63a0c2c5a7113237af8ecb41cfca8/ash/resources/ash_resources.grd [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_1x.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_3g_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_3g_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_4g_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_4g_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_arcs_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_arcs_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_bars_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_bars_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_edge_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_edge_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_evdo_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_evdo_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_gprs_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_gprs_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_lte_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_lte_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_roaming_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_roaming_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_secure_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_network_vpn_badge.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_100_percent/cros/network/statusbar_wired.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/status_wifi_enabled.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_3g_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_3g_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_4g_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_4g_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_arcs_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_arcs_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_bars_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_bars_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_edge_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_edge_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_evdo_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_evdo_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_gprs_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_gprs_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_lte_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_lte_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_roaming_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_roaming_light.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_secure_dark.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_network_vpn_badge.png [delete] https://crrev.com/84dfd8a7c64d9a00126cf447e225aed5bf41486e/ash/resources/default_200_percent/cros/network/statusbar_wired.png
I had VpnDefaultView cleanup as part of this bug too, is that piece blocked on something else (such as the VPN icon redesign?)
sorry, missed that part of the report
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4b0179113bfaf5389faae5c95a3ac21dbeeafd3 commit c4b0179113bfaf5389faae5c95a3ac21dbeeafd3 Author: estade <estade@chromium.org> Date: Thu Feb 16 00:57:22 2017 Remove non-md code from tray_vpn.cc BUG= 686233 Review-Url: https://codereview.chromium.org/2696193002 Cr-Commit-Position: refs/heads/master@{#450851} [modify] https://crrev.com/c4b0179113bfaf5389faae5c95a3ac21dbeeafd3/ash/common/system/chromeos/network/network_icon.cc [modify] https://crrev.com/c4b0179113bfaf5389faae5c95a3ac21dbeeafd3/ash/common/system/chromeos/network/network_icon.h [modify] https://crrev.com/c4b0179113bfaf5389faae5c95a3ac21dbeeafd3/ash/common/system/chromeos/network/tray_vpn.cc
Comment 1 by tdander...@chromium.org
, Feb 7 2017