New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686226 link

Starred by 3 users
Status: Fixed
Owner:
se...@chromium.org
Closed: Jan 2018
Cc:
█ apaci...@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PersonalDataManagerTest.SaveImportedProfile" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jan 27 2017 
"PersonalDataManagerTest.SaveImportedProfile" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitQZXJzb25hbERhdGFNYW5hZ2VyVGVzdC5TYXZlSW1wb3J0ZWRQcm9maWxlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by tsergeant@chromium.org, Jan 30 2017

Owner: se...@chromium.org
Status: Assigned (was: Untriaged)
I'm about to land a CL to disable this test, along with PersonalDataManagerTest.MergeProfile_UsageStats, which appears to have a couple of flakes as well.

The tests are only flaky on TSan, with error messages like

../../components/autofill/core/browser/personal_data_manager_unittest.cc:4519: Failure
Expected: (base::TimeDelta::FromMilliseconds(500)) > (base::Time::Now() - saved_profiles.front()->use_date()), actual: 0.5 s vs 1.41471 s

This suggests to me (with no knowledge of the test itself) that the failures are just because TSan builds are slow.

Assigning to sebsg@, who seems to be the author of this test.

Comment 2 by tsergeant@chromium.org, Jan 30 2017

Labels: -Sheriff-Chromium
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3df95e516ae237ef93d88cd4bcd1bddffe4d2bd6

commit 3df95e516ae237ef93d88cd4bcd1bddffe4d2bd6
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Jan 31 00:09:22 2017

Disable flaky PersonalDataManagerTests on TSan builds

Two tests are flaking on TSan:
- PersonalDataManagerTest.SaveImportedProfile
- PersonalDataManagerTest.MergeProfile_UsageStats

BUG= 686226 
TBR=sebsg@chromium.org

Review-Url: https://codereview.chromium.org/2667823002
Cr-Commit-Position: refs/heads/master@{#447119}

[modify] https://crrev.com/3df95e516ae237ef93d88cd4bcd1bddffe4d2bd6/components/autofill/core/browser/personal_data_manager_unittest.cc
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Jan 31 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "PersonalDataManagerTest.SaveImportedProfile". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitQZXJzb25hbERhdGFNYW5hZ2VyVGVzdC5TYXZlSW1wb3J0ZWRQcm9maWxlDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 5 by tsergeant@chromium.org, Jan 31 2017

Labels: -Sheriff-Chromium

Comment 6 by se...@chromium.org, Feb 1 2017

Status: Started (was: Assigned)
Thanks, I was actually working on the base issue, ie: setting up custom times for tests. It landed today so I'll reenable the test with some modifications!
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c96270769554e8cab52297f141afc49ee868bce

commit 1c96270769554e8cab52297f141afc49ee868bce
Author: sebsg <sebsg@chromium.org>
Date: Thu Feb 02 02:17:59 2017

[Autofill] Make use of the test clock for Flaky test SaveImportedProfile

BUG= 686226 

Review-Url: https://codereview.chromium.org/2666313003
Cr-Commit-Position: refs/heads/master@{#447688}

[modify] https://crrev.com/1c96270769554e8cab52297f141afc49ee868bce/components/autofill/core/browser/personal_data_manager_unittest.cc

Comment 8 by ma...@chromium.org, Jan 16 2018

Status: Fixed (was: Started)

Comment 9 by ma...@chromium.org, Jan 16 2018

Cc: apaci...@chromium.org ma...@chromium.org
 Issue 669729  has been merged into this issue.
►

Sign in to add a comment