New issue
Advanced search Search tips

Issue 686220 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 686224
issue 686291



Sign in to add a comment

Cleanup of non-MD code common to Ash system menu detailed views

Project Member Reported by tdander...@chromium.org, Jan 27 2017

Issue description

Clean up the non-MD code which is common across all detailed views, specifically TrayDetailsView.

 
Blocking: 686224
Blocking: 686291
Labels: Hotlist-CodeHealth
Labels: -M-58 M-59

Comment 5 by est...@chromium.org, Mar 28 2017

Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1653e00e3ecd7b208e4fb00265492263c86367bf

commit 1653e00e3ecd7b208e4fb00265492263c86367bf
Author: estade <estade@chromium.org>
Date: Wed Mar 29 20:44:13 2017

Remove pre-MD code from TrayDetailsView.

Remove SpecialPopupRow.

BUG= 686220 

Review-Url: https://codereview.chromium.org/2780743002
Cr-Commit-Position: refs/heads/master@{#460527}

[modify] https://crrev.com/1653e00e3ecd7b208e4fb00265492263c86367bf/ash/BUILD.gn
[modify] https://crrev.com/1653e00e3ecd7b208e4fb00265492263c86367bf/ash/common/system/chromeos/audio/tray_audio.cc
[delete] https://crrev.com/c785f2a0d65bbac2f5f896862e1ad21b38acb3ad/ash/common/system/tray/special_popup_row.cc
[delete] https://crrev.com/c785f2a0d65bbac2f5f896862e1ad21b38acb3ad/ash/common/system/tray/special_popup_row.h
[modify] https://crrev.com/1653e00e3ecd7b208e4fb00265492263c86367bf/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/1653e00e3ecd7b208e4fb00265492263c86367bf/ash/common/system/tray/tray_details_view.h
[modify] https://crrev.com/1653e00e3ecd7b208e4fb00265492263c86367bf/ash/common/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/1653e00e3ecd7b208e4fb00265492263c86367bf/ash/resources/ash_resources.grd
[delete] https://crrev.com/c785f2a0d65bbac2f5f896862e1ad21b38acb3ad/ash/resources/default_100_percent/cros/status/status_less.png
[delete] https://crrev.com/c785f2a0d65bbac2f5f896862e1ad21b38acb3ad/ash/resources/default_200_percent/cros/status/status_less.png

Comment 7 by est...@chromium.org, Mar 31 2017

Status: Fixed (was: Started)
Labels: code-change
Status: Verified (was: Fixed)

Sign in to add a comment