New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 686217 link

Starred by 1 user
Status: Verified
Owner:
█ tdander...@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove mappings from PNG assets to vector icons in Ash UI code

Project Member Reported by tdander...@chromium.org, Jan 27 2017 
Now that MD shelf/system menu is enabled by default, remove all functions which map non-MD PNG asset IDs to MD vector icon IDs, and perform any other MD-related cleanup in the following classes:

TrayImageItem
LabelTrayView
TrayAudioDelegate
TrayNotificationView

Comment 1 by tdander...@chromium.org, Feb 7 2017

Labels: Hotlist-CodeHealth

Comment 2 by tdander...@chromium.org, Feb 15 2017

Status: Started (was: Assigned)
https://codereview.chromium.org/2700653002/
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf

commit d76a3c6165fa6b8d279372c7c4cd5f383d63cecf
Author: tdanderson <tdanderson@chromium.org>
Date: Fri Feb 17 22:53:10 2017

[Ash MD] Remove pre-MD code from TrayImageItem and subclasses

Remove the pre-MD code and now-unused PNG assets
from the TrayImageItem class, its subclasses,
and associated default rows in the Ash system menu.

BUG= 686217 , 686256 , 687813 , 687814 , 687815 , 687818 
TEST=manual, no functional changes

Review-Url: https://codereview.chromium.org/2700653002
Cr-Commit-Position: refs/heads/master@{#451392}

[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/chromeos/audio/tray_audio.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/tray/tray_image_item.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/tray/tray_image_item.h
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/resources/ash_resources.grd
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_accessibility_mode.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_auto_rotate_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_auto_rotate_locked.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_auto_rotate_locked_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_capslock.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_capslock_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_tracing.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_dark_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_update_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_100_percent/cros/status/status_volume_mute.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_accessibility_mode.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_auto_rotate_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_auto_rotate_locked.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_auto_rotate_locked_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_capslock.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_capslock_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_tracing.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_dark_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_green.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_orange.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_update_red.png
[delete] https://crrev.com/b25fc47b3517d87ea086cea8a6b96a562c2dee01/ash/resources/default_200_percent/cros/status/status_volume_mute.png
[modify] https://crrev.com/d76a3c6165fa6b8d279372c7c4cd5f383d63cecf/ash/system/chromeos/rotation/tray_rotation_lock.cc

Comment 4 by tdander...@chromium.org, Feb 22 2017 

LabelTrayView changes: https://codereview.chromium.org/2715463004

Comment 5 by tdander...@chromium.org, Mar 7 2017

Labels: -M-58 M-59
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e9d1d70b20868d1f0ae07133eb3ca23928f213

commit 69e9d1d70b20868d1f0ae07133eb3ca23928f213
Author: tdanderson <tdanderson@chromium.org>
Date: Thu Mar 30 15:25:53 2017

Remove non-MD code from LabelTrayView

Remove the non-MD code paths from LabelTrayView, a class
used in the Ash system menu. Also remove the now-unused
PNG image assets for enterprise, session length limit,
child user, and supervised user.

BUG= 686217 

Review-Url: https://codereview.chromium.org/2715463004
Cr-Commit-Position: refs/heads/master@{#460764}

[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/common/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/common/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/common/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/common/system/chromeos/supervised/tray_supervised_user.h
[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/common/system/tray/label_tray_view.cc
[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/common/system/tray/label_tray_view.h
[modify] https://crrev.com/69e9d1d70b20868d1f0ae07133eb3ca23928f213/ash/resources/ash_resources.grd
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_100_percent/cros/status/status_child_user.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_100_percent/cros/status/status_managed.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_100_percent/cros/status/status_managed_mode_user.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_100_percent/cros/status/status_session_length_timer.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_200_percent/cros/status/status_child_user.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_200_percent/cros/status/status_managed.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_200_percent/cros/status/status_managed_mode_user.png
[delete] https://crrev.com/b6082fccb8e9fc2f21871508bdcf79ca567326ad/ash/resources/default_200_percent/cros/status/status_session_length_timer.png
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673de101a2b30b905462441b12828a83f85d02d7

commit 673de101a2b30b905462441b12828a83f85d02d7
Author: tdanderson <tdanderson@chromium.org>
Date: Mon Apr 03 19:58:36 2017

[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG= 686217 , 685845 
TEST=manual
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2785273002
Cr-Commit-Position: refs/heads/master@{#461512}

[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/BUILD.gn
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/common/system/tray/tray_notification_view.cc
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/common/system/tray/tray_notification_view.h
[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/common/system/tray_accessibility.h
[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/resources/ash_resources.grd
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/resources/default_100_percent/cros/status/status_accessibility_dark.png
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/resources/default_200_percent/cros/status/status_accessibility_dark.png

Comment 8 by tdander...@chromium.org, Apr 3 2017

Status: Fixed (was: Started)
TrayAudioDelegate was removed in https://codereview.chromium.org/2778503002, so all classes mentioned in #0 have now been addressed.

Comment 9 by sdantul...@chromium.org, May 8 2017

Labels: code-change
Status: Verified (was: Fixed)
►

Sign in to add a comment