Move Wi-Fi on/off bubble into the notification center |
||||||||||
Issue descriptionOn Ash, if WiFi is enabled or disabled using a keyboard shortcut, a bubble appears above the system tray showing "Wi-Fi is turned off." This should probably be sent as a notification in the notification center instead.
,
Feb 6 2017
,
Feb 7 2017
,
Feb 7 2017
,
Mar 7 2017
fukino@ I'm removing the milestone label on these for the time being; please re-triage as you see fit.
,
Apr 14 2017
,
Apr 14 2017
,
Apr 18 2017
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/081c5abe1f023603f1af0db522848988255b4a7c commit 081c5abe1f023603f1af0db522848988255b4a7c Author: tetsui <tetsui@google.com> Date: Mon Apr 24 01:47:44 2017 ash: Move "WiFi is turned on." buble to the notification center. When WiFi is enabled with WiFi toggle key, "WiFi is turned on." bubble pops up. However, the bubble was not using the notification center. If you don't have the key on your Chromebook, enable chrome://flags/#ash-debug-shortcuts then Ctrl-Shift-Alt-N. BUG= 686206 TEST=manually tested. Review-Url: https://codereview.chromium.org/2817423002 Cr-Commit-Position: refs/heads/master@{#466576} [modify] https://crrev.com/081c5abe1f023603f1af0db522848988255b4a7c/ash/system/network/tray_network.cc [modify] https://crrev.com/081c5abe1f023603f1af0db522848988255b4a7c/ash/system/network/tray_network.h [modify] https://crrev.com/081c5abe1f023603f1af0db522848988255b4a7c/ash/system/system_notifier.cc [modify] https://crrev.com/081c5abe1f023603f1af0db522848988255b4a7c/ash/system/system_notifier.h
,
Apr 24 2017
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0d84463b0969956171b6149d2a9f0a4c083c9f5 commit b0d84463b0969956171b6149d2a9f0a4c083c9f5 Author: tetsui <tetsui@google.com> Date: Wed Apr 26 02:35:53 2017 ash: Remove NetworkDetailedView. As NetworkWifiDetailedView bubble was transformed into notification, now NetworkStateListDetailedView is the only subclass of NetworkDetailedView. Therefore, the interface is no longer needed. BUG= 686206 Review-Url: https://codereview.chromium.org/2835133002 Cr-Commit-Position: refs/heads/master@{#467209} [modify] https://crrev.com/b0d84463b0969956171b6149d2a9f0a4c083c9f5/ash/BUILD.gn [delete] https://crrev.com/c70a7b06bdfa97f21c7db551e2de61e3be34bf6a/ash/system/network/network_detailed_view.h [modify] https://crrev.com/b0d84463b0969956171b6149d2a9f0a4c083c9f5/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/b0d84463b0969956171b6149d2a9f0a4c083c9f5/ash/system/network/network_state_list_detailed_view.h [modify] https://crrev.com/b0d84463b0969956171b6149d2a9f0a4c083c9f5/ash/system/network/tray_network.h [modify] https://crrev.com/b0d84463b0969956171b6149d2a9f0a4c083c9f5/ash/system/network/tray_vpn.h [modify] https://crrev.com/b0d84463b0969956171b6149d2a9f0a4c083c9f5/chrome/browser/ui/ash/networking_config_delegate_chromeos_browsertest.cc
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tdander...@chromium.org
, Jan 27 2017