New issue
Advanced search Search tips

Issue 686203 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 686210



Sign in to add a comment

Move the Ash "caps lock is enabled" bubble to the notifications center

Project Member Reported by tdander...@chromium.org, Jan 27 2017

Issue description

Currently the first time a user enables caps lock (Alt+Search), a bubble pops up to say "Caps lock is enabled, press Alt+Search or Shift to disable". This should probably be moved into the notification center instead.

 
Blocking: 686210
Components: UI>Shell>Notifications
Owner: fukino@chromium.org
Status: Assigned (was: Available)
Labels: -M-58
fukino@ I'm removing the milestone label on these for the time being; please re-triage as you see fit.

Comment 6 by fukino@chromium.org, Apr 13 2017

Cc: fukino@chromium.org
Owner: tetsui@chromium.org
tetsui@ is looking into this. Thanks!
Labels: M-59
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f0af475fd6e46a14e6a33cc538e5b24c86ab803

commit 3f0af475fd6e46a14e6a33cc538e5b24c86ab803
Author: tetsui <tetsui@google.com>
Date: Fri Apr 14 02:30:43 2017

ash: Move "CAPS LOCK is on." bubble to the notification center.

When caps lock is enabled with Alt+Search, "CAPS LOCK is on." bubble
pops up. However, the bubble was not using the notification center.

BUG= 686203 
TEST=manually tested.

Review-Url: https://codereview.chromium.org/2820443002
Cr-Commit-Position: refs/heads/master@{#464659}

[modify] https://crrev.com/3f0af475fd6e46a14e6a33cc538e5b24c86ab803/ash/system/system_notifier.cc
[modify] https://crrev.com/3f0af475fd6e46a14e6a33cc538e5b24c86ab803/ash/system/system_notifier.h
[modify] https://crrev.com/3f0af475fd6e46a14e6a33cc538e5b24c86ab803/ash/system/tray_caps_lock.cc
[modify] https://crrev.com/3f0af475fd6e46a14e6a33cc538e5b24c86ab803/ash/system/tray_caps_lock.h

Comment 9 by tetsui@chromium.org, Apr 14 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
9534.0.0, 60.0.3092.0

Sign in to add a comment