New issue
Advanced search Search tips

Issue 686196 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 715114



Sign in to add a comment

WebMouseEvents Enter/Leave translated into Move

Project Member Reported by dtapu...@chromium.org, Jan 27 2017

Issue description

Inside blink MouseEnter/MouseLeave get translated into MouseMove events.

These events should just be dealt with as enter and leave and really shouldn't need translation.
 
Labels: -Hotlist-Infra-DX Hotlist-Input-Dev

Comment 3 by mustaq@chromium.org, Apr 25 2017

Blocking: 715114
Owner: lanwei@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b40772db092d28a4abfa3b0d869b0cb9815f3d1b

commit b40772db092d28a4abfa3b0d869b0cb9815f3d1b
Author: lanwei <lanwei@chromium.org>
Date: Thu Apr 27 14:58:42 2017

Do not convert mouse move events to mouse leave events in blink

In blink, we convert mouse enter and leave events to mouse move events,
we should not do it anymore. We should keep their types, so we know
they are actual enter or leave events.

I looked at the code, PointerEventManager::SendMousePointerEvent has a
separate argument called mouse_event_type, which is always the type of
mouse move, and mouseevent's type is not referred anymore. It should
be safe to remove the conversion.

BUG= 686196 

Review-Url: https://codereview.chromium.org/2839103002
Cr-Commit-Position: refs/heads/master@{#467674}

[modify] https://crrev.com/b40772db092d28a4abfa3b0d869b0cb9815f3d1b/third_party/WebKit/Source/web/WebInputEventConversion.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment