New issue
Advanced search Search tips

Issue 686191 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Improper use of booleans causes compilation failures with libjpeg >= 9

Reported by griffon26phone@gmail.com, Jan 27 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0

Steps to reproduce the problem:
1. update libjpeg to version 9
2. build chromium

What is the expected behavior?
Compilation succeeds.

What went wrong?
Compilation failed in chromium/ui/gfx/codec/jpeg_codec.cc because of various invalid conversions from int to boolean or bool to boolean.

I attached a patch to solve these issues.

Did this work before? No 

Chrome version: git master  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 24.0 r0

The compilation error only shows with libjpeg-9, but the code should already have used the proper definitions of TRUE and FALSE before.
 
chromium-jpeg-9-booleans-fix.patch
1.9 KB Download
Components: Internals>Images>Codecs

Comment 2 by noel@chromium.org, Feb 1 2017

Cc: noel@chromium.org

Comment 3 by ajha@chromium.org, Feb 3 2017

Labels: TE-NeedsTriageHelp
Adding 'TE-NeedsTriageHelp'' label to move this issue out of TE Unconfirmed triaging bucket.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 12 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment