Hi would you be a little more specific? Do you mean the _use_ of bold is not consistent, or inconsistency within the font itself across platforms?

Thanks

sabineb@ to final confirm:

It's only for the autofill popup on *password* form i.e. "Use password for: / [stored username]". Suggested treatment is the use of *regular font weight* not bold. See the img attached. 

A reasoning is that the bold weight is used for the labels which are to be filled in the selected form field. For the autofill popup on *password* form, the username is not to be filled. The regular font weight, that is used for "Chrome Autofill settings..." row, is a better fit. 

Deleted: 686186.png 16.1 KB

	686186.png 16.1 KB View Download

Sabine, could you confirm Hwi's mocks in c#2 are correct?

Fonts just aren't going to be totally consistent across platforms. For example it's pretty common that a system font won't have support for medium weight, so then our options are to either not use the system font (bad) or use a different weight, either normal or bold (less bad). Or a font that is listed as "medium" might be bolder than you'd expect, as the font itself actually decides precisely what medium is to look like.

ChromeOS is the only one we'll have full control over. We probably do want to worry about Windows and Mac, but may need to accept we won't be able to use certain weights. Linux is always just a best effort.

See for example[1] which has some discussion of font weight wrt harmony buttons.

[1] https://chromium.googlesource.com/chromium/src/+/0faeac167d0af1df458fd5edf988f42f339d49f6

Updated the title
- Original: Autofill bold font is not consistent
- New: Use regular weight for password autofill popup label
- Reason: on c2

Side note (probably not directly related to this bug): per c4 & crbug.com/567755#c19, on Linux, Win, Mac, labels will be in bold and sublabels in regular weight. On CrOS, it's best if labels are in medium weight (fallback is bold).  

Yes, I agree that it shouldn't be bold in this case if that's inconsistent with other Autofill UI. dvadym, could you please change this according to comment #2? Thanks

As far as I understand a text should be in bold when it's to be filled. Then there are actually 2 cases, the popup is shown on a username field and the popup is shown on a password field (screenshots attached), so usernames should be bold when the popup is shown on a username field and regular when on a password field. 
Hwi, could you please confirm this?

Deleted: username_field_popup.png 4.3 KB

	username_field_popup.png 4.3 KB View Download

Deleted: password_field_popup.png 5.3 KB

	password_field_popup.png 5.3 KB View Download

> usernames should be bold when the popup is shown on a username field and regular when on a password field

Correct. Thanks dvadym!

Dvadym, do you have a general timeline when you think this might be fixed, so I can let ui-review know? (they asked during our most recent ui-review for Form Not Secure)

CL https://codereview.chromium.org/2681703002/ for fixing this is in code review.  emilyschechter, should the fix be merged to M-57?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3db819dfcac399579102ecb93917c48d6769ce

commit fb3db819dfcac399579102ecb93917c48d6769ce
Author: dvadym <dvadym@chromium.org>
Date: Wed Feb 08 10:22:02 2017

Use regular weight for password autofill popup on password field.

A text in password suggestion popup should be bold iff this text is to be autofilled. So on a username field Username in the suggestion popup should be bold, but on a password field Username should be in regular text.

BUG= 686186 

Review-Url: https://codereview.chromium.org/2681703002
Cr-Commit-Position: refs/heads/master@{#448945}

[modify] https://crrev.com/fb3db819dfcac399579102ecb93917c48d6769ce/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/fb3db819dfcac399579102ecb93917c48d6769ce/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/fb3db819dfcac399579102ecb93917c48d6769ce/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/fb3db819dfcac399579102ecb93917c48d6769ce/components/autofill/core/browser/popup_item_ids.h
[modify] https://crrev.com/fb3db819dfcac399579102ecb93917c48d6769ce/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/fb3db819dfcac399579102ecb93917c48d6769ce/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Popup on a password field is in regular text now. Screenshots are attached.

Hwi, could you please check that UI after this fix is what you expected?

Deleted: username_field_popup.png 3.9 KB

	username_field_popup.png 3.9 KB View Download

Deleted: password_field_popup.png 5.7 KB

	password_field_popup.png 5.7 KB View Download

LGTM - Thanks dvadym@!

If we can merge it, that would be nice, but if we need to wait for 58 that is OK.

Ok, let's try to merge. The patch is small, so there shouldn't be any problems.

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb7bedd52c831328f3569501450ed8d8bc724ca9

commit bb7bedd52c831328f3569501450ed8d8bc724ca9
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Fri Feb 10 13:58:54 2017

[Merge] Use regular weight for password autofill popup on password field.

A text in password suggestion popup should be bold iff this text is to be autofilled. So on a username field Username in the suggestion popup should be bold, but on a password field Username should be in regular text.

BUG= 686186 

Review-Url: https://codereview.chromium.org/2681703002
Cr-Commit-Position: refs/heads/master@{#448945}
(cherry picked from commit fb3db819dfcac399579102ecb93917c48d6769ce)

Review-Url: https://codereview.chromium.org/2684393003 .
Cr-Commit-Position: refs/branch-heads/2987@{#435}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/bb7bedd52c831328f3569501450ed8d8bc724ca9/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/bb7bedd52c831328f3569501450ed8d8bc724ca9/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/bb7bedd52c831328f3569501450ed8d8bc724ca9/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/bb7bedd52c831328f3569501450ed8d8bc724ca9/components/autofill/core/browser/popup_item_ids.h
[modify] https://crrev.com/bb7bedd52c831328f3569501450ed8d8bc724ca9/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/bb7bedd52c831328f3569501450ed8d8bc724ca9/components/password_manager/core/browser/password_autofill_manager_unittest.cc

Merged. It will be in next beta.