NQE: Mark ECT as ambiguous if there is a change in the connection type |
||||||||
Issue descriptionEffective connection type (ECT) provided by Network Quality Estimator (NQE) should be marked as ambiguous if there is a change in the connection type. Currently, it is possible that user is on a slow 2G connection, ECT is Unknown, user loads a couple of webpages, ECT may still remain Unknown. Then, the connection type changes to a fast connection, and ECT is computed as 4G. With that, all the page loads (including those on the slow 2G connection) would be marked with ECT of 4G.
,
Jan 30 2017
,
Jan 30 2017
,
Jan 30 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/370efa3eede2c0aa3000895523637dea28b9c502 commit 370efa3eede2c0aa3000895523637dea28b9c502 Author: Tarun Bansal <tbansal@google.com> Date: Mon Jan 30 22:05:52 2017 Mark ECT as ambiguous if there is a change in the connection type. Mark EffectiveConnectionType (ECT) as ambiguous in the system profile proto when there is a change in the connection type. BUG= 686157 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2661563004 Cr-Commit-Position: refs/heads/master@{#446938} (cherry picked from commit e931fa7ddaf6e747b369e433aba0bdf791b2d3a3) Review-Url: https://codereview.chromium.org/2663023002 . Cr-Commit-Position: refs/branch-heads/2987@{#195} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/370efa3eede2c0aa3000895523637dea28b9c502/components/metrics/net/network_metrics_provider.cc [modify] https://crrev.com/370efa3eede2c0aa3000895523637dea28b9c502/components/metrics/net/network_metrics_provider.h [modify] https://crrev.com/370efa3eede2c0aa3000895523637dea28b9c502/components/metrics/net/network_metrics_provider_unittest.cc
,
Jan 30 2017
,
Feb 13 2017
,
Feb 14 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jan 29 2017