New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686149 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in sizes at 446383:446383

Project Member Reported by pras...@chromium.org, Jan 27 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=686149

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgsLXLsAoM


Bot(s) for this bug's original alert(s):

mac
Labels: OS-Mac OS-Windows
Owner: paulir...@chromium.org
Status: Assigned (was: Untriaged)
There is only one CL in the changelog.
paulirish@, Do you think https://crrev.com/446383 might have cause this change in the sizes. If it is not, then please feel free to assign this issue back to me.
Yup, I can take care of this.  CL coming in to address the size regression.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e358e50b02e5dca9633b9a96291c659871b56fe5

commit e358e50b02e5dca9633b9a96291c659871b56fe5
Author: paulirish <paulirish@chromium.org>
Date: Fri Jan 27 20:59:45 2017

DevTools: flip lighthouse binary to be a remote module.

BUG= 686149 

Review-Url: https://codereview.chromium.org/2658233003
Cr-Commit-Position: refs/heads/master@{#446765}

[modify] https://crrev.com/e358e50b02e5dca9633b9a96291c659871b56fe5/third_party/WebKit/Source/devtools/front_end/audits2_worker.json

Heya Prasad, are  you seeing the numbers here return to normal? I'd expect it to, but not entirely sure I'm using the perf dashboard correctly.
The metric doesn't seem to have recovered.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbfa0cc27ff472e0911c74160eb05d87d4c14a2b

commit cbfa0cc27ff472e0911c74160eb05d87d4c14a2b
Author: paulirish <paulirish@chromium.org>
Date: Fri Mar 03 03:08:16 2017

DevTools: finalize audits2 worker as remote module

BUG= 686149 

Review-Url: https://codereview.chromium.org/2725853004
Cr-Commit-Position: refs/heads/master@{#454489}

[modify] https://crrev.com/cbfa0cc27ff472e0911c74160eb05d87d4c14a2b/third_party/WebKit/Source/devtools/BUILD.gn

Status: Fixed (was: Assigned)
@alexclarke, thanks for the confirmation on this.

After the above CL, it looks like we've recovered. 
Screen Shot 2017-03-02 at 10.51.58 PM.png
94.6 KB View Download
Labels: Binary-Size
Labels: -binary-size Performance-Size

Sign in to add a comment