New issue
Advanced search Search tips

Issue 686147 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
mrefaat@chromium.org
pwnall@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Evaluate if CookieStoreIOSPersistent needs to inherit from CookieStoreIOS

Project Member Reported by eugene...@chromium.org, Jan 27 2017 
Inheritance make things complex and we should revisit if it is even needed here.

Inheritance introduced here:
https://codereview.chromium.org/2649083002/diff/140001/ios/net/cookies/cookie_store_ios_persistent.h?context=10&column_width=80&tab_spaces=8

Comment 1 by eugene...@chromium.org, Aug 2 2017

Cc: mrefaat@chromium.org
CookieStoreIOSPersistent only reads cookie from system_store_, CookieStoreIOS reads and writes cookie to system_store_. Inheritance can be replaces with a boolean flag.

Comment 2 by eugene...@chromium.org, Aug 2 2017

Labels: -Type-Feature Type-Task

Comment 3 by pwnall@chromium.org, Feb 22 2018

Cc: pwnall@chromium.org

Comment 4 by mmenke@chromium.org, May 9 2018

Labels: Network-Triaged
►

Sign in to add a comment