Show "cannot distinguish card types" warning instead of rejecting with NotSupportedError. |
||||||
Issue descriptionAdding `supportedTypes` in `PaymentMethodData.data` will cause a rejection unless it has all 3 types 'credit', 'debit' and 'prepaid'. Otherwise devs should completely remove `supportedTypes`. This will cause a confusion and extra work for developers in the future. So we should allow `supportedTypes` with 1 or 2 arguments and show a warning message in console instead: "Cannot yet distinguish credit, debit, and prepaid cards."
,
Jan 30 2017
,
Jan 30 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b commit 06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Mon Jan 30 20:52:00 2017 [Merge M-57] Relax card type handling. Chrome does not yet differentiate between the various `supportedTypes` ['credit', 'debit', 'prepaid'] in `PaymentMethodData.data`. To warn developers of this behavior, we now allow `supportedTypes` with 1 or 2 arguments and show a warning message in developer console instead: "Cannot yet distinguish credit, debit, and prepaid cards." BUG= 686119 Review-Url: https://codereview.chromium.org/2659083003 Cr-Commit-Position: refs/heads/master@{#446996} (cherry picked from commit 06a0d2103e3207a176f4b3b98537106854a4ec00) Review-Url: https://codereview.chromium.org/2662043002 . Cr-Commit-Position: refs/branch-heads/2987@{#184} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBasicCardTest.java [modify] https://crrev.com/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b/chrome/test/data/payments/basic_card.js [modify] https://crrev.com/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b/chrome/test/data/payments/payment_request_basic_card_test.html [modify] https://crrev.com/06a557a4c7c5bfdb7bfd3ad058d6f9179464d08b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
,
Jan 30 2017
,
Jun 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jan 30 2017