New issue
Advanced search Search tips

Issue 686109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 685244



Sign in to add a comment

NGInlineLayoutTest.BlockWithTextAndAtomicInline failing on ClangToTLinuxASan

Project Member Reported by thakis@chromium.org, Jan 27 2017

Issue description

https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan%20tester/builds/1841/steps/webkit_unit_tests/logs/NGInlineLayoutTest.BlockWithTextAndAtomicInline

=================================================================
==12186==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0x65a366 in __interceptor_malloc /b/c/b/ClangToTLinuxASan/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cc:64
    #1 0xbd86fa0 in PartitionAlloc base/allocator/partition_allocator/partition_alloc.h:702:18
    #2 0xbd86fa0 in blink::InlineBox::operator new(unsigned long) third_party/WebKit/Source/core/layout/line/InlineBox.cpp:81
    #3 0xba0aea6 in blink::LayoutBox::createInlineBox() third_party/WebKit/Source/core/layout/LayoutBox.cpp:2028:10
    #4 0xb9bb8ca in createInlineBox third_party/WebKit/Source/core/layout/api/LineLayoutBox.h:97:50
    #5 0xb9bb8ca in createInlineBoxForLayoutObject third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:134
    #6 0xb9bb8ca in blink::LayoutBlockFlow::constructLine(blink::BidiRunList<blink::BidiRun>&, blink::LineInfo const&) third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:296
    #7 0xbe5952f in blink::NGLineBuilder::CopyFragmentDataToLayoutBlockFlow() third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc:192:38
    #8 0xbe3b029 in blink::NGInlineLayoutAlgorithm::Layout() third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc:54:17
    #9 0x896405 in blink::NGInlineLayoutTest_BlockWithTextAndAtomicInline_Test::TestBody() third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp:81:12
    #10 0x7210697 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #11 0x7210697 in testing::Test::Run() testing/gtest/src/gtest.cc:2474
    #12 0x72121e4 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #13 0x72134a6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #14 0x72291d6 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #15 0x72286b5 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #16 0x72286b5 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255
    #17 0x7166ba6 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #18 0x7166ba6 in base::TestSuite::Run() base/test/test_suite.cc:271
    #19 0x914c72 in (anonymous namespace)::runHelper(base::TestSuite*) third_party/WebKit/Source/web/tests/RunAllTests.cpp:48:27
    #20 0x7169eb8 in Run base/callback.h:85:12
    #21 0x7169eb8 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211
    #22 0x7169ace in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #23 0x914abd in main third_party/WebKit/Source/web/tests/RunAllTests.cpp:70:10
    #24 0x7f11c776f7ec in __libc_start_main /build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226

Started in this build: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan%20tester/builds/1830

(the bot was down 6 days before that build)

Not clear if this is due to an asan build or a real leak. The latter feels more likely (layout-ng folks?), but the pinned memory bots don't see it. So I guess something has changed in upstream asan?
 

Comment 1 by e...@chromium.org, Jan 27 2017

Owner: glebl@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by glebl@chromium.org, Feb 2 2017

Owner: kojii@chromium.org
I think it started failing after http://crrev.com/2594003003. reassigning to kojii@ who is more familiar with that code.

Comment 3 by r...@chromium.org, Feb 8 2017

Cc: r...@chromium.org

Comment 4 by r...@chromium.org, Feb 8 2017

Cc: -r...@chromium.org kojii@chromium.org
Owner: r...@chromium.org
Status: Fixed (was: Assigned)
I was unable to reproduce this locally, and this bot cycled green in https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan%20tester/builds/1859, so I think this has been fixed.

Comment 5 by kojii@chromium.org, Feb 9 2017

Oh great, thank you Reid!

Sign in to add a comment