Bisect - Repro'ing test failures but not continuing |
|||
Issue descriptionAFAIK it's actually reproducing the failures but we don't seem to be continuing bisecting after that.
,
Jan 27 2017
Wow, didn't think of this at all. Will work on fix.
,
Jan 27 2017
I think this simple fix should do the trick. https://chromium-review.googlesource.com/c/433330/
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/2933ae7994ff7089034c13e106c1ba94807cad2d commit 2933ae7994ff7089034c13e106c1ba94807cad2d Author: Mike Case <mikecase@google.com> Date: Fri Jan 27 20:30:44 2017 Fix tee.py eating return code for commands it wraps. The fact that tee.py always return 0 exit code breaks bisect. BUG=686080 Change-Id: I2b1904ffafcb2f761c420e211ac597fa6fbec5aa Reviewed-on: https://chromium-review.googlesource.com/433330 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Michael Case <mikecase@chromium.org> Commit-Queue: Michael Case <mikecase@chromium.org> [modify] https://crrev.com/2933ae7994ff7089034c13e106c1ba94807cad2d/scripts/slave/tee.py
,
Feb 3 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by simonhatch@chromium.org
, Jan 27 2017