New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686058 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 29 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Editing a template's content from DevTools disconnects the DevTools and crashes the tab.

Reported by krist...@derfor.dk, Jan 27 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.76 Safari/537.36

Steps to reproduce the problem:
1. Create an HTML file with the contents:
`<html>
<body>
<template><p>Hello, world</p></template>
</body>
</html>`
2. Open the file in the browser.
3. Open DevTools.
4. Navigate to the <p>Hello, world</p> element in the Elements tab in DevTools.
5. Right-click <p>Hello, world</p> and click "Edit as HTML".
6. Apply any changes to the element (e.g. add a character, remove the element).

What is the expected behavior?
The changes are applied to the DOM and everybody lives happily ever after.

What went wrong?
The tab view turns into "Aw, Snap!" and DevTools crashes with "DevTools was disconnected from the page".

Did this work before? Yes It was also broken in 55, so prior to that. Don't know when.

Chrome version: 56.0.2924.76  Channel: stable
OS Version: OS X 10.12.0
Flash Version: Shockwave Flash 24.0 r0
 
Screen Shot 2017-01-27 at 14.35.05.png
147 KB View Download
Labels: M-57 Needs-Bisect
Status: Untriaged (was: Unconfirmed)
I am able to reproduce this issue on Current Stable#56.0.2924.76 for Win7 64-bit OS.
Owner: lushnikov@chromium.org
Labels: -Needs-Bisect -Type-Bug-Regression Stability-Crash OS-Linux OS-Windows Type-Bug
Able to reproduce this issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12 using chrome latest stable M56-56.0.2924.76 by following steps mentioned in the original comment. 

This is a non-regression issue seen from M35-35.0.1849.0, Hence marking it as untriaged.

There are few crash Id's but the stack trace is not getting generated.
Crash Id's : a9e2c7e880000000, 52e847e880000000

Thanks!
Finally stack trace got generated for the above report ID's:
-----------------------------------------------------------------

Stack Trace:
--------------
Thread 0 CRASHED [SIGSEGV @ 0x00000010 ] MAGIC SIGNATURE THREAD
Stack Quality100%Show frame trust levels
0x00007f804a97478b	(chrome -./out/Release/../../third_party/WebKit/Source/core/dom/Node.h:838 )	blink::DOMPatchSupport::patchNode(blink::Node*, WTF::String const&, blink::ExceptionState&)
0x00007f804a96f71a	(chrome -./out/Release/../../third_party/WebKit/Source/core/inspector/DOMEditor.cpp:238 )	blink::DOMEditor::SetOuterHTMLAction::perform(blink::ExceptionState&)
0x00007f804a93b14c	(chrome -./out/Release/../../third_party/WebKit/Source/core/inspector/InspectorHistory.cpp:78 )	<name omitted>
0x00007f804a970296	(chrome -./out/Release/../../third_party/WebKit/Source/core/inspector/DOMEditor.cpp:420 )	blink::DOMEditor::setOuterHTML(blink::Node*, WTF::String const&, blink::Node**)
0x00007f804a927447	(chrome -./out/Release/../../third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp:864 )	blink::InspectorDOMAgent::setOuterHTML(int, WTF::String const&)
0x00007f804a92b7ac	(chrome -./out/Release/../../third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp )	non-virtual thunk to blink::InspectorDOMAgent::setOuterHTML(int, WTF::String const&)
0x00007f80480ad83f	(chrome -./out/Release/gen/blink/core/inspector/protocol/DOM.cpp:1840 )	blink::protocol::DOM::DispatcherImpl::setOuterHTML(int, std::unique_ptr<blink::protocol::DictionaryValue, std::default_delete<blink::protocol::DictionaryValue> >, blink::protocol::ErrorSupport*)
0x00007f804808639b	(chrome -./out/Release/gen/blink/core/inspector/protocol/Accessibility.cpp:477 )	blink::protocol::Accessibility::DispatcherImpl::dispatch(int, WTF::String const&, std::unique_ptr<blink::protocol::DictionaryValue, std::default_delete<blink::protocol::DictionaryValue> >)
0x00007f80480e4c8a	(chrome -./out/Release/gen/blink/core/inspector/protocol/Protocol.cpp:827 )	blink::protocol::UberDispatcher::dispatch(std::unique_ptr<blink::protocol::Value, std::default_delete<blink::protocol::Value> >, int*, WTF::String*)
0x00007f804a954a82	(chrome -./out/Release/../../third_party/WebKit/Source/core/inspector/InspectorSession.cpp:84 )	blink::InspectorSession::dispatchProtocolMessage(WTF::String const&, WTF::String const&)
0x00007f804a2f478b	(chrome -./out/Release/../../third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:528 )	blink::WebDevToolsAgentImpl::dispatchOnInspectorBackend(int, int, blink::WebString const&, blink::WebString const&)
0x00007f804b1a55ea	(chrome -./out/Release/../../content/renderer/devtools/devtools_agent.cc:266 )	content::DevToolsAgent::OnDispatchOnInspectorBackend(int, int, std::string const&, std::string const&)
0x00007f804b1a5850	(chrome -./out/Release/../../base/tuple.h:91 )	bool IPC::MessageT<DevToolsAgentMsg_DispatchOnInspectorBackend_Meta, std::tuple<int, int, std::string, std::string>, void>::Dispatch<content::DevToolsAgent, content::DevToolsAgent, void, void (content::DevToolsAgent::*)(int, int, std::string const&, std::string const&)>(IPC::Message const*, content::DevToolsAgent*, content::DevToolsAgent*, void*, void (content::DevToolsAgent::*)(int, int, std::string const&, std::string const&))
0x00007f804b1a444b	(chrome -./out/Release/../../content/renderer/devtools/devtools_agent.cc:107 )	content::DevToolsAgent::OnMessageReceived(IPC::Message const&)
0x00007f804b0af4c2	(chrome -./out/Release/../../content/renderer/render_frame_impl.cc:1513 )	content::RenderFrameImpl::OnMessageReceived(IPC::Message const&)
0x00007f8048a01d39	(chrome -./out/Release/../../ipc/ipc_channel_proxy.cc:329 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&)
0x00007f804857f49d	(chrome -./out/Release/../../base/callback.h:68 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x00007f804a24fb4c	(chrome -./out/Release/../../third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:519 )	blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*)
0x00007f804a24ef14	(chrome -./out/Release/../../third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:316 )	blink::scheduler::TaskQueueManager::DoWork(bool)
0x00007f804857f49d	(chrome -./out/Release/../../base/callback.h:68 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x00007f8048515acf	(chrome -./out/Release/../../base/message_loop/message_loop.cc:421 )	base::MessageLoop::RunTask(base::PendingTask*)
0x00007f80485155c4	(chrome -./out/Release/../../base/message_loop/message_loop.cc:430 )	base::MessageLoop::DoWork()
0x00007f80485170e4	(chrome -./out/Release/../../base/message_loop/message_pump_default.cc:33 )	base::MessagePumpDefault::Run(base::MessagePump::Delegate*)
0x00007f8048533b4f	(chrome -./out/Release/../../base/run_loop.cc:37 )	base::RunLoop::Run()
0x00007f804b109050	(chrome -./out/Release/../../content/renderer/renderer_main.cc:200 )	content::RendererMain(content::MainFunctionParams const&)
0x00007f804819332e	(chrome -./out/Release/../../content/app/content_main_runner.cc:362 )	content::RunZygote(content::MainFunctionParams const&, content::ContentMainDelegate*)
0x00007f804819447b	(chrome -./out/Release/../../content/app/content_main_runner.cc:813 )	content::ContentMainRunnerImpl::Run()
0x00007f8048192eed	(chrome -./out/Release/../../content/app/content_main.cc:20 )	content::ContentMain(content::ContentMainParams const&)
0x00007f8046de6870	(chrome -./out/Release/../../chrome/app/chrome_main.cc:112 )	ChromeMain
0x00007f803f8cbf44	(libc-2.19.so -libc-start.c:287 )	__libc_start_main
0x00007f8046de66e0	(chrome + 0x00b406e0 )	_start
Labels: -Pri-2 Pri-1
Status: Fixed (was: Untriaged)
The crash seems to be fixed with https://chromium-review.googlesource.com/c/chromium/src/+/745325

Sign in to add a comment