Issue metadata
Sign in to add a comment
|
Flake in SOM go tests |
||||||||||||||||||||||
Issue descriptionfrom https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.infra%2Finfra-continuous-win-64%2F5403%2F%2B%2Frecipes%2Fsteps%2Finfra_go_tests%2F0%2Fstdout which closed infra tree. Please fix. x............................................................................................................................. Failures: * E:/b/rr/tmpmn75in/w/infra/go/src/infra/appengine/sheriff-o-matic/som/main_test.go Line 255: Expected: '(*som.swarmingAlerts){Dead:[]*swarming.SwarmingRpcsBotInfo(nil), Quarantined:[]*swarming.SwarmingRpcsBotInfo(nil), Error:[]string{"googleapi: Error 403: , forbidden", "googleapi: Error 403: , forbidden"}}' Actual: '(*som.swarmingAlerts){Dead:[]*swarming.SwarmingRpcsBotInfo(nil), Quarantined:[]*swarming.SwarmingRpcsBotInfo(nil), Error:[]string{"googleapi: Error 403: , forbidden", "Get https://chromium-swarm.appspot.com/_ah/api/swarming/v1/bots/list?alt=json&is_dead=TRUE: dial tcp 173.194.219.141:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond."}}' (Should resemble)! 322 total assertions --- FAIL: TestMain (21.11s) FAIL coverage: 80.2% of statements FAIL infra/appengine/sheriff-o-matic/som 21.164s
,
Jan 27 2017
This test should not be making live http connections.
,
Jan 27 2017
Tiffany, this is your code, right?
,
Jan 27 2017
I think Sean technically wrote this specific test (fetching dead swarming bots), but I think I also wrote similar tests which might be doing network requests to Monorail. At any rate, I'm on it.
,
Jan 30 2017
,
Jan 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/f9b54cdcf8079c9e977ffff48fda1ef5f0925f9d commit f9b54cdcf8079c9e977ffff48fda1ef5f0925f9d Author: Tiff Zhang <zhangtiff@google.com> Date: Mon Jan 30 21:42:37 2017 SoM: Fix flaky go test. BUG= 686053 Change-Id: Ie018637396631512f94f6ab465e0192ad6459d62 Reviewed-on: https://chromium-review.googlesource.com/434543 Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/f9b54cdcf8079c9e977ffff48fda1ef5f0925f9d/go/src/infra/appengine/sheriff-o-matic/Makefile [modify] https://crrev.com/f9b54cdcf8079c9e977ffff48fda1ef5f0925f9d/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
,
Jan 31 2017
I fixed the flake in the test for now, but we will still want to change the test to actually be more useful. So I am leaving this bug open but lowering the priority.
,
May 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Jan 27 2017