New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 686035 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: In Supervised user, on removing locked main profile, fresh profile does not launch.

Reported by lpa...@etouch.net, Jan 27 2017

Issue description

Chrome Version: 57.0.2987.13 (Official Build) 9d5a5f205754b7ea50a90a3f2c8d0675ca50bf1a-refs/branch-heads/2987@{#134} (32/64-bit)
OS: Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

Precondition: Sign in to chrome and from chrome://settings, add/import a supervised user.

What steps will reproduce the problem?
1) Launch chrome, click on avatar icon and select 'Exit and childlock' option.
2) In Switch person window, switch to supervised user and then navigate to chrome://settings.
3) In 'People' section, select main user (locked profile), remove the user and observe.

On removing locked profile, fresh normal profile does not launch.

On removing locked profile, fresh normal profile should launch.

This is a Regression issue broken in M-57, will soon update other info
Manual bisect:
Good build: 57.0.2931.0
Bad build: 57.0.2933.0
 
supervise_actual.mov
4.5 MB Download
supervise_expected.mov
4.6 MB Download
Cc: bauerb@chromium.org jmukthavaram@chromium.org pa...@yandex-team.ru
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: anthonyvd@chromium.org
Status: Assigned (was: Unconfirmed)
Please find the below per-revision bisect information:
Good build: 57.0.2931.0- Revision-434310
Bad build: 57.0.2933.0-- Revision-434540

Bisect Tool Info:
----------------
You are probably looking for a change made after 434462 (known good), but no later than 434463 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/56f03f53c9dd7cd2977b6e06dd724f07187124a7..198d711e1e047b20d235c430a697f1b39a651b08

Review-Url: https://codereview.chromium.org/2519953004

anthonyvd@ assigning to you, as you were listed as one of the reviewers for this CL.

Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.
Thank you!
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5cdb47188549b4d5c9ce8905dc8d1edd797cd07

commit c5cdb47188549b4d5c9ce8905dc8d1edd797cd07
Author: palar <palar@yandex-team.ru>
Date: Tue Jan 31 15:26:37 2017

Upon deletion of the profile don't fallback on current if it supervised.

BUG= 686035 

R=anthonyvd@chromium.org, bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2659803003
Cr-Commit-Position: refs/heads/master@{#447235}

[modify] https://crrev.com/c5cdb47188549b4d5c9ce8905dc8d1edd797cd07/chrome/browser/profiles/profile_manager.cc

Labels: TE-Verified-58.0.2999.0 TE-Verified-M58
Verified this issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12 using chrome latest canary M58-58.0.2999.0 by following steps mentioned in the original comment. Observed on removing locked profile, fresh normal profile is getting launched as expected. Hence adding TE-Verified label.
686035.ogv
5.5 MB View Download
A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Issue is fixed and verified on M58, can we have a merge request so that the CL can be merged to M57 and can be verified.

Note: Issue is tagged with M57 and stable blocker labels.

Comment 6 by bauerb@chromium.org, Feb 14 2017

Labels: Merge-Request-57
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 14 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 14 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e07ec0b608ad9b0470e4da7c4f4e89765ef5ad74

commit e07ec0b608ad9b0470e4da7c4f4e89765ef5ad74
Author: Bernhard Bauer <bauerb@chromium.org>
Date: Tue Feb 14 12:08:15 2017

Upon deletion of the profile don't fallback on current if it supervised.

BUG= 686035 

R=anthonyvd@chromium.org, bauerb@chromium.org

Review-Url: https://codereview.chromium.org/2659803003
Cr-Commit-Position: refs/heads/master@{#447235}
(cherry picked from commit c5cdb47188549b4d5c9ce8905dc8d1edd797cd07)

Review-Url: https://codereview.chromium.org/2694813004 .
Cr-Commit-Position: refs/branch-heads/2987@{#497}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/e07ec0b608ad9b0470e4da7c4f4e89765ef5ad74/chrome/browser/profiles/profile_manager.cc

Labels: TE-Verified-57.0.2987.54 TE-Verified-M57
Verified the issue on Mac 10.12.2, Win 10 and Ubuntu 14.04 using 57.0.2987.54 and its working fine,Added respective TE-verified labels for the same.
686035_Feb_15.mp4
2.4 MB View Download
A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
Please mark as fixed is there is no pending work here. Thank you.

URGENT - PTAL ASAP.

We're getting VERY close to M57 Stable promotion. And 
this issue is marked as M57 stable release blocker. Pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion).

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label or move to M58.

Thank you.
Status: Fixed (was: Assigned)
Marking as fixed per comment #3 and #9. 

Sign in to add a comment