New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685993 link

Starred by 19 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Devtools: AltGr+[ and AltGr+] issue on Belgian keyboard layout

Reported by labora...@gmail.com, Jan 27 2017

Issue description

Chrome Version       : 58.0.2993.0
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1.have the Windows keyboard layout set to Belgian(Period)
2.open chrome with any page and open devtools
3.go to console and try to type [ or ] on the commandline

What is the expected result?
I would expect to see [] outputted in the console

What happens instead of that?

Devtools cycles between the different tabs
It seems that AltGr is recognised as Ctrl...

UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.2993.0 Safari/537.36



 
Components: Platform>DevTools
Labels: Needs-Triage-M58

Comment 2 by woxxom@gmail.com, Jan 29 2017

Also reported in  issue 685674 .
Quote:
	Bisect: 445634 (good) - 445645 (bad)
	https://chromium.googlesource.com/chromium/src/+log/2322e5d5..91d7a775?pretty=fuller
	The only devtools-related change is r445638 "DevTools: restore shortcuts to switch devtool panel left/right" - tracked in  issue 683140 .
	Typing [] in an Italian keyboard layout requires pressing AltGr (right-side Alt), which gets misinterpreted as a tab-switch modifier.
Owner: einbinder@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85d052a58e40fa393e1daa4e3b1848c2b0530607

commit 85d052a58e40fa393e1daa4e3b1848c2b0530607
Author: einbinder <einbinder@chromium.org>
Date: Wed Feb 08 00:54:50 2017

DevTools: Don't trigger panel switcher shortcut if alt key is held

On Windows with some international keyboard layouts, typing [ might
report that both ctrl and alt are pressed.

BUG= 685993 

Review-Url: https://codereview.chromium.org/2680773003
Cr-Commit-Position: refs/heads/master@{#448824}

[modify] https://crrev.com/85d052a58e40fa393e1daa4e3b1848c2b0530607/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

 Issue 690133  has been merged into this issue.
 Issue 691260  has been merged into this issue.

Comment 7 by ajha@chromium.org, Feb 21 2017

Labels: -Needs-Triage-M58 TE-Verified-M58 TE-Verified-58.0.3018.0 M-58
Status: Assigned (was: Unconfirmed)
Verified the fix on the latest canary(58.0.3018.0) on Windows-10 and this is WAI. AltGr+8/9 enters [] in the console without switching the tabs.

einbinder@: Please close the issue if there is no further work to be done here.
685993.png
132 KB View Download
Cc: ranjitkan@chromium.org pbomm...@chromium.org einbinder@chromium.org gov...@chromium.org dgozman@chromium.org brajkumar@chromium.org
 Issue 685674  has been merged into this issue.
Labels: ReleaseBlock-Stable Merge-Request-57
(I explicitly asked that this was merged in the code review...)
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 15 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This is a one-line fix that landed on Feb 8th. More that one month in Canary with no issues, safe to merge.
Labels: -Merge-Review-57 M-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on comment #12. Please merge ASAP. Thank you.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 15 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e36e1c3d473f53199e9bdfb841fcfaf4c317dad

commit 8e36e1c3d473f53199e9bdfb841fcfaf4c317dad
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Mar 15 20:04:53 2017

DevTools: Don't trigger panel switcher shortcut if alt key is held

On Windows with some international keyboard layouts, typing [ might
report that both ctrl and alt are pressed.

BUG= 685993 

Review-Url: https://codereview.chromium.org/2680773003
Cr-Commit-Position: refs/heads/master@{#448824}
(cherry picked from commit 85d052a58e40fa393e1daa4e3b1848c2b0530607)

Review-Url: https://codereview.chromium.org/2751833009 .
Cr-Commit-Position: refs/branch-heads/2987@{#829}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/8e36e1c3d473f53199e9bdfb841fcfaf4c317dad/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

Status: Fixed (was: Assigned)
einbinder@/pfeldman@, Requesting a postmortem for this issue. 
(please see go/chrome-postmortems for the process to follow). Thank you.
Labels: TE-Verified-57.0.2987.110 TE-Verified-57
Verified this issue on Windows-10 using chrome latest stable M57-57.0.2987.110 by following steps mentioned in the comment #7, Observed the square braces is printed in console as expected. Hence adding TE-Verified label.

Thanks!
 Issue 702032  has been merged into this issue.
 Issue 703117  has been merged into this issue.
Requesting a postmortem for this (please see go/chrome-postmortems for the process to follow). Thank you.
 Issue 707564  has been merged into this issue.

Sign in to add a comment