New issue
Advanced search Search tips

Issue 685987 link

Starred by 1 user
Status: Fixed
Owner:
pinkerton@chromium.org
Closed: Feb 2017
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Leak in snapshot_cache_unittest.mm

Project Member Reported by jif@chromium.org, Jan 27 2017 
Data returned by CGDataProviderCopyData is not released.
This should be fixed by using base::ScopedCFTypeRef.

Comment 1 by jasonkliu@chromium.org, Feb 9 2017

Labels: Hotlist-GoodFirstBug

Comment 2 by pinkerton@chromium.org, Feb 10 2017

Owner: pinkerton@chromium.org
Status: Assigned (was: Available)
I'll take this. CL in progress.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0054e56fe7741328be8091e7f620f3a3f76faac9

commit 0054e56fe7741328be8091e7f620f3a3f76faac9
Author: pinkerton <pinkerton@chromium.org>
Date: Fri Feb 10 20:39:39 2017

Fix memory leak in SaveToDisk.

Fix a memory leak in SaveToDisk by getting rid of the helper function
and moving the access to the raw pixels inline. This allows the
intermediate CFData object to be correctly refcounted.

BUG= 685987 
TEST=none, test passes

Review-Url: https://codereview.chromium.org/2686213003
Cr-Commit-Position: refs/heads/master@{#449723}

[modify] https://crrev.com/0054e56fe7741328be8091e7f620f3a3f76faac9/ios/chrome/browser/snapshots/snapshot_cache_unittest.mm

Comment 4 by pinkerton@chromium.org, Feb 10 2017

Status: Fixed (was: Assigned)
Fixed.
►

Sign in to add a comment