New issue
Advanced search Search tips

Issue 685972 link

Starred by 2 users
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Mar 2017
Cc:
jlebel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 681309


Show other hotlists

Hotlists containing this issue:
web-bluetooth


Sign in to add a comment

bluetooth: mac: Improve error message debugging

Project Member Reported by fbeaufort@chromium.org, Jan 27 2017 
It would be nice to add more VLOG on macOS as it is hard to Bluetooth debug issues like https://bugs.chromium.org/p/chromium/issues/detail?id=681309 for instance.

Existing VLOGs like the one below would also benefit of extra information about characteristic properties.

 VLOG(1) << "Bluetooth error while reading for characteristic, domain: "
              << base::SysNSStringToUTF8(error.domain)
              << ", error code: " << error.code;

Comment 2 by fbeaufort@chromium.org, Jan 27 2017

Blocking: 681309

Comment 3 by ortuno@chromium.org, Feb 13 2017

Status: Available (was: Untriaged)

Comment 4 by fbeaufort@chromium.org, Mar 1 2017

Cc: jlebel@chromium.org
Owner: ----

Comment 5 by jlebel@chromium.org, Mar 13 2017

Owner: jlebel@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234aec4f17e0b08204b0e8df547ab7426100b404

commit 234aec4f17e0b08204b0e8df547ab7426100b404
Author: jlebel <jlebel@chromium.org>
Date: Wed Mar 22 08:59:36 2017

Bluetooth: macOS: Adding logs

Adding logs for macOS adapter, devices, services, characteristics and descriptors.

BUG= 685972 

Review-Url: https://codereview.chromium.org/2745983003
Cr-Commit-Position: refs/heads/master@{#458691}

[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_low_energy_device_mac.h
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_low_energy_device_mac.mm
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.h
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_remote_gatt_characteristic_mac.mm
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_remote_gatt_descriptor_mac.h
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_remote_gatt_descriptor_mac.mm
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_remote_gatt_service_mac.h
[modify] https://crrev.com/234aec4f17e0b08204b0e8df547ab7426100b404/device/bluetooth/bluetooth_remote_gatt_service_mac.mm

Comment 7 by ortuno@chromium.org, Mar 28 2017

Status: Fixed (was: Started)
Thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7b01a5ecefb707c69f90baa0850d5d7570215a

commit bf7b01a5ecefb707c69f90baa0850d5d7570215a
Author: jlebel <jlebel@chromium.org>
Date: Fri Mar 31 08:37:33 2017

Adding log in BluetoothAdapterMac::CreateGattConnection() and BluetoothAdapterMac::DisconnectGatt()

And removing from BluetoothLowEnergyDeviceMac::CreateGattConnectionImpl() and BluetoothLowEnergyDeviceMac::DisconnectGatt()

This is to make sure no log are missed (when calling directly BluetoothAdapterMac).

BUG= 685972 

Review-Url: https://codereview.chromium.org/2783283002
Cr-Commit-Position: refs/heads/master@{#461079}

[modify] https://crrev.com/bf7b01a5ecefb707c69f90baa0850d5d7570215a/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/bf7b01a5ecefb707c69f90baa0850d5d7570215a/device/bluetooth/bluetooth_low_energy_device_mac.mm
►

Sign in to add a comment