New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685967 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 685680
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

telemetry_perf_unittests: browse:media:imgur test crashes or timeout

Project Member Reported by kjellander@chromium.org, Jan 27 2017

Issue description

At several bots, telemetry_perf_unittests has started to flake and is failing the browse:media:imgur test.
 
First failure on Linux: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51290 (#446442)
shows a crash in https://chromium-swarm.appspot.com/task?id=33f58119a2e6f310&refresh=10&show_raw=1

Later on: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51314 the test is not crashing, but still failing:
https://chromium-swarm.appspot.com/task?id=33f7c6d0eebb3d10&refresh=10&show_raw=1

On Mac the first failures are:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/12648 (#446428)
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/7031 (#446428)

and on Windows:
https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/20358

I have a hard time figuring out a culprit since
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/51289 (#446431) is green (which is newer than the first failing Mac builds above).

I'll try to figure out how to disable this test, but it seems hard.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c38e44cd64dcbc514f25f2e6fa5aea28a9116ca

commit 9c38e44cd64dcbc514f25f2e6fa5aea28a9116ca
Author: kjellander <kjellander@chromium.org>
Date: Fri Jan 27 09:14:28 2017

Disable browse:media:imgur in telemetry_perf_unittests

BUG= 685967 
TBR=nednguyen@google.com
NOTRY=True

Review-Url: https://codereview.chromium.org/2661503005
Cr-Commit-Position: refs/heads/master@{#446628}

[modify] https://crrev.com/9c38e44cd64dcbc514f25f2e6fa5aea28a9116ca/tools/perf/benchmarks/system_health_smoke_test.py

Cc: perezju@chromium.org nednguyen@chromium.org
Owner: bmeu...@chromium.org
Assign to bmeurer@ because you last touch the code in the crash stack:


Thread 17 (crashed)
0 chrome!v8::base::OS::Abort() + 0xf
rax = 0x0000000000000000 rdx = 0x0000000000000000
rcx = 0x0000000000000001 rbx = 0x00007fa6746c6460
rsi = 0x00007fa690427a80 rdi = 0x00007fa690426180
rbp = 0x0000000000000348 rsp = 0x00007fa6746c6388
r8 = 0x00007fa6746c7700 r9 = 0x00007fa6901b6510
r10 = 0x00000000ffffff00 r11 = 0x0000000000000000
r12 = 0x0000000000000005 r13 = 0x00007fa69ca3227c
r14 = 0x00007fa69c666aef r15 = 0x00007fa690426828
rip = 0x00007fa699de3f0f
Found by: given as instruction pointer in context
1 0x3000000028
rbx = 0x00007fa6746c6460 rbp = 0x0000000000000348
rsp = 0x00007fa6746c6398 r12 = 0x0000000000000005
r13 = 0x00007fa69ca3227c r14 = 0x00007fa69c666aef
r15 = 0x00007fa690426828 rip = 0x0000003000000028
Found by: call frame info
2 chrome!_fini + 0x78f8e
rsp = 0x00007fa6746c63d8 rip = 0x00007fa69c6668da
Found by: stack scanning
3 chrome!v8::internal::compiler::GraphReducer::Replace(v8::internal::compiler::Node*, v8::internal::compiler::Node*, unsigned int) + 0x4a1
rsp = 0x00007fa6746c6400 rip = 0x00007fa697db9421
Found by: stack scanning
4 0x1ea2b49a1018
rbx = 0x00007fa697dae2db rbp = 0x00001ea2b4df4b00
rsp = 0x00007fa6746c65b0 r12 = 0x00001ea2b4df4a08
r13 = 0x00001ea2b4df49d8 r14 = 0x0000000000000000
r15 = 0x00001ea2b49efa00 rip = 0x00001ea2b49a1018
Found by: call frame info
5 chrome!v8::internal::compiler::EscapeAnalysis::ProcessEffectPhi(v8::internal::compiler::Node*) + 0x25e
rsp = 0x00007fa6746c6600 rip = 0x00007fa697db198e
Found by: stack scanning
6 0x1ea2b4df4d48
rbx = 0x00001ea2b59a4390 rbp = 0x0000000000000020
rsp = 0x00007fa6746c6650 r12 = 0x0000000000000000
r13 = 0x0000000000000000 r14 = 0x00007fa6746c6658
r15 = 0x00007fa6746c66b0 rip = 0x00001ea2b4df4d48
Found by: call frame info
7 chrome!v8::internal::compiler::EscapeStatusAnalysis::CheckUsesForEscape(v8::internal::compiler::Node*, v8::internal::compiler::Node*, bool) + 0x1e0
rsp = 0x00007fa6746c6680 rip = 0x00007fa697daee60
Found by: stack scanning
8 chrome!v8::internal::compiler::EscapeStatusAnalysis::ProcessFinishRegion(v8::internal::compiler::Node*) + 0x4e
rbx = 0x00001ea2b49a1920 rbp = 0x00001ea2b49efa00
rsp = 0x00007fa6746c66d0 r12 = 0x00007fa6746c6858
r13 = 0x00001ea2b49a1920 r14 = 0x00001ea2b4e07018
r15 = 0x00001ea2b4e083c8 rip = 0x00007fa697dae91e
Found by: call frame info
9 chrome!v8::internal::compiler::EscapeStatusAnalysis::RunStatusAnalysis() + 0xb8
rbx = 0x00001ea2b49a1920 rbp = 0x00001ea2b49efa00
rsp = 0x00007fa6746c6710 r12 = 0x00007fa6746c6858
r13 = 0x0000000000000000 r14 = 0x00001ea2b4e07018
r15 = 0x00001ea2b4e083c8 rip = 0x00007fa697dae3c8
Found by: call frame info
10 chrome!v8::internal::compiler::EscapeAnalysis::Run() + 0x14e
rbx = 0x00007fa6746c6858 rbp = 0x00001ea2b49efa00
rsp = 0x00007fa6746c6730 r12 = 0x00007fa6746c6858
r13 = 0x0000000000000000 r14 = 0x00007fa6746c6898
r15 = 0x00001ea2b4e083c8 rip = 0x00007fa697daf12e
Found by: call frame info
11 chrome!v8::internal::compiler::EscapeAnalysisPhase::Run(v8::internal::compiler::PipelineData*, v8::internal::Zone*) + 0x51
rbx = 0x00001ea2b4262298 rbp = 0x00001ea2b49efa00
rsp = 0x00007fa6746c6760 r12 = 0x00007fa6746c6858
r13 = 0x0000000000000000 r14 = 0x00001ea2b49efa00
r15 = 0x00001ea2b42623b0 rip = 0x00007fa697e3ee01
Found by: call frame info
12 chrome!v8::internal::compiler::PipelineImpl::OptimizeGraph(v8::internal::compiler::Linkage*) + 0x205
rbx = 0x00001ea2b4262298 rbp = 0x00001ea2b49efa00
rsp = 0x00007fa6746c6970 r12 = 0x00001ea2b4262088
r13 = 0x0000000000000000 r14 = 0x00001ea2b4262298
r15 = 0x00001ea2b42623b0 rip = 0x00007fa697e38295
Found by: call frame info
13 chrome!v8::internal::compiler::PipelineCompilationJob::ExecuteJobImpl() + 0x14
rbx = 0x00001ea2b4262000 rbp = 0x00007fa69e111280
rsp = 0x00007fa6746c6a10 r12 = 0x00001ea2b56f42c0
r13 = 0x00001ea2b56f44d0 r14 = 0x000000039b69defa
r15 = 0x00001ea2b56f4ac0 rip = 0x00007fa697e38084
Found by: call frame info
14 chrome!v8::internal::CompilationJob::ExecuteJob() + 0x8e
rbx = 0x00001ea2b4262000 rbp = 0x00007fa69e111280
rsp = 0x00007fa6746c6a20 r12 = 0x00001ea2b56f42c0
r13 = 0x00001ea2b56f44d0 r14 = 0x000000039b69defa
r15 = 0x00001ea2b56f4ac0 rip = 0x00007fa697d6380e
Found by: call frame info
15 chrome!v8::internal::OptimizingCompileDispatcher::CompileNext(v8::internal::CompilationJob*) + 0x18
rbx = 0x00001ea2b0361780 rbp = 0x00007fa69e111280
rsp = 0x00007fa6746c6a70 r12 = 0x00007fa6746c6b58
r13 = 0x00007fa69e163880 r14 = 0x00001ea2b0361780
r15 = 0x00001ea2b4262000 rip = 0x00007fa697d62a38
Found by: call frame info
16 chrome!v8::internal::OptimizingCompileDispatcher::CompileTask::Run() + 0x130
rbx = 0x00007fa69e111540 rbp = 0x00007fa69e111280
rsp = 0x00007fa6746c6a90 r12 = 0x00007fa6746c6b58
r13 = 0x00007fa69e163880 r14 = 0x00001ea2b0361780
r15 = 0x00007fa6746c6b20 rip = 0x00007fa697d634c0
Found by: call frame info
17 chrome!base::(anonymous namespace)::WorkerThread::ThreadMain() + 0x2a8
rbx = 0x00007fa6746c6bb0 rbp = 0x00007fa69e111280
rsp = 0x00007fa6746c6af0 r12 = 0x00007fa6746c6b58
r13 = 0x00007fa69e163880 r14 = 0x00007fa69c824775
r15 = 0x00007fa6746c6b20 rip = 0x00007fa698b28d18
Found by: call frame info
18 chrome!base::(anonymous namespace)::ThreadFunc(void*) + 0x63
rbx = 0x00007fa6746c7700 rbp = 0x00001ea2b02bcdd0
rsp = 0x00007fa6746c6c50 r12 = 0x00007ffd15fab5b0
r13 = 0x00007fa6746c79c0 r14 = 0x00001ea2b5640800
r15 = 0x0000000000000003 rip = 0x00007fa698b224d3
Found by: call frame info
19 libpthread-2.15.so + 0x7e9a
rbx = 0x0000000000000000 rbp = 0x0000000000000000
rsp = 0x00007fa6746c6c70 r12 = 0x00007ffd15fab5b0
r13 = 0x00007fa6746c79c0 r14 = 0x00001ea2b51d5c70
r15 = 0x0000000000000003 rip = 0x00007fa6964ffe9a
Found by: call frame info
20 libc-2.15.so + 0xf336d
rsp = 0x00007fa6746c6d80 rip = 0x00007fa69016136d
Found by: stack scanning


(This is from https://chromium-swarm.appspot.com/task?id=33f58119a2e6f310&refresh=10&show_raw=1)
Cc: bmeu...@chromium.org jarin@chromium.org
Components: Blink>JavaScript>Compiler
Labels: -OS-Linux -OS-Windows -OS-Mac Arch-All OS-All
Owner: tebbi@chromium.org
Looks like we have a test for the memory corruption now.

Comment 4 by tebbi@chromium.org, Jan 31 2017

Mergedinto: 685680
Status: Duplicate (was: Assigned)

Comment 5 by tebbi@chromium.org, Jan 31 2017

The logs show this message:

# Fatal error in ../../v8/src/compiler/escape-analysis.cc, line 840
# Encountered unaccounted use by #92 (Call)

Status: Assigned (was: Duplicate)
Is this now fixed then?

The test should be re-enabled.

Comment 7 by tebbi@chromium.org, Jan 31 2017

Yes, this is fixed and rolled to the canaries.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ba56b29db3c657a5d2378e846a02b11d6dc7e1

commit 53ba56b29db3c657a5d2378e846a02b11d6dc7e1
Author: nednguyen <nednguyen@google.com>
Date: Tue Jan 31 13:19:16 2017

Revert of Disable browse:media:imgur in telemetry_perf_unittests (patchset #2 id:20001 of https://codereview.chromium.org/2661503005/ )

Reason for revert:
The root cause should be fixed in  crbug.com/685680 

Original issue's description:
> Disable browse:media:imgur in telemetry_perf_unittests
>
> BUG= 685967 
> TBR=nednguyen@google.com
> NOTRY=True
>
> Review-Url: https://codereview.chromium.org/2661503005
> Cr-Commit-Position: refs/heads/master@{#446628}
> Committed: https://chromium.googlesource.com/chromium/src/+/9c38e44cd64dcbc514f25f2e6fa5aea28a9116ca

TBR=kjellander@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 685967 

Review-Url: https://codereview.chromium.org/2662213003
Cr-Commit-Position: refs/heads/master@{#447225}

[modify] https://crrev.com/53ba56b29db3c657a5d2378e846a02b11d6dc7e1/tools/perf/benchmarks/system_health_smoke_test.py

Comment 9 by tebbi@chromium.org, Feb 6 2017

Status: Duplicate (was: Assigned)

Sign in to add a comment