https://chromium-review.googlesource.com/#/c/433402/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b7da32c3314b2ed4bb35b0d0efd25f755cecf78d

commit b7da32c3314b2ed4bb35b0d0efd25f755cecf78d
Author: Kirtika Ruchandani <kirtika@chromium.org>
Date: Thu Feb 02 20:29:32 2017

debugd: Add support for Intel wifi to WifiDebugTool

WifiDebugTool class currently only handles enabling
verbose driver logging via sysfs flags for marvell wifi.
Enable this for Intel as well.
Currently only provides "all or none" debugging for iwlwifi,
setting /sys/module/iwlwifi/parameters/debug to 0xffffffff or 0x0.
More granularity can be added in the future.

BUG= chromium:685956 
TEST=built and ran on Caroline
(1) "network_logging wifi" in crosh should cause log spew in a shell
with "tail -f /var/log/messages | grep iwl" and
"network_logging reset" should stop spew.
(2)`dbus-send --system --print-reply --dest=org.chromium.debugd \
/org/chromium/debugd org.chromium.debugd.SetWifiDriverDebug int32:0`
`dbus-send --system --print-reply --dest=org.chromium.debugd \
/org/chromium/debugd org.chromium.debugd.SetWifiDriverDebug int32:1`

Change-Id: I70840203d3080e2b481cb3fee221597da3ea69e7
Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/433402
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/b7da32c3314b2ed4bb35b0d0efd25f755cecf78d/debugd/src/wifi_debug_tool.cc
[modify] https://crrev.com/b7da32c3314b2ed4bb35b0d0efd25f755cecf78d/debugd/src/wifi_debug_tool.h

Sameer, Kevin,
If you approve, could I mark this for M56 merging?
I am looking at two cases:
(a) if Caroline is shipping with M56 out of the factory and runs into hang issues. 
(b) potentially use this for https://code.google.com/p/chrome-os-partner/issues/detail?id=52804 if we encounter folks in the field

I'd run it past Grace and advise her on the risk/rewards so she can make the call.

+Grace

Caroline will be force-AUed to M58 when customers receive units.

Given M56 has gone stable, I would recommend against merging to it.  We should merge to M57 though.

Approving merge to M57 Chrome OS.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b3b6e4063c8349ff650622e7d3cfcb4fbf3271ff

commit b3b6e4063c8349ff650622e7d3cfcb4fbf3271ff
Author: Kirtika Ruchandani <kirtika@chromium.org>
Date: Fri Feb 10 20:28:54 2017

debugd: Add support for Intel wifi to WifiDebugTool

WifiDebugTool class currently only handles enabling
verbose driver logging via sysfs flags for marvell wifi.
Enable this for Intel as well.
Currently only provides "all or none" debugging for iwlwifi,
setting /sys/module/iwlwifi/parameters/debug to 0xffffffff or 0x0.
More granularity can be added in the future.

BUG= chromium:685956 
TEST=built and ran on Caroline
(1) "network_logging wifi" in crosh should cause log spew in a shell
with "tail -f /var/log/messages | grep iwl" and
"network_logging reset" should stop spew.
(2)`dbus-send --system --print-reply --dest=org.chromium.debugd \
/org/chromium/debugd org.chromium.debugd.SetWifiDriverDebug int32:0`
`dbus-send --system --print-reply --dest=org.chromium.debugd \
/org/chromium/debugd org.chromium.debugd.SetWifiDriverDebug int32:1`

Change-Id: I70840203d3080e2b481cb3fee221597da3ea69e7
Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/433402
Reviewed-by: Brian Norris <briannorris@chromium.org>
(cherry picked from commit b7da32c3314b2ed4bb35b0d0efd25f755cecf78d)
Reviewed-on: https://chromium-review.googlesource.com/440444

[modify] https://crrev.com/b3b6e4063c8349ff650622e7d3cfcb4fbf3271ff/debugd/src/wifi_debug_tool.cc
[modify] https://crrev.com/b3b6e4063c8349ff650622e7d3cfcb4fbf3271ff/debugd/src/wifi_debug_tool.h