New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685950 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need RAPPPOR metrics for unused RTCPeerConnections

Project Member Reported by hta@chromium.org, Jan 27 2017

Issue description

Some of our metrics indicate that a large number of users create PeerConnection objects, but never use them to connect.

We'd like to have more information about what is happening in those cases. One way of gathering more information is to add ETLD+1 recording of unconnected PeerConnections, like we currently do for video, audio and datachannels.

The usual privacy preservation considerations are in effect.

 

Comment 1 by hta@chromium.org, Jan 27 2017

Cc: tommi@chromium.org juberti@chromium.org
This is based on a discussion from November 2016, which doesn't seem to have resulted in filing a bug before this.

Comment 3 by hta@chromium.org, Jan 31 2017

Labels: Merge-Request-57
It would be great to get stats earlier, so asking for DI to 57.

Project Member

Comment 4 by sheriffbot@chromium.org, Jan 31 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 6 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 7 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fea3fead2754330f7d7566d7fca4602342b6355f

commit fea3fead2754330f7d7566d7fca4602342b6355f
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Feb 07 19:41:46 2017

RAPPOR metric for usage of RTCPeerConnection without connecting.

This is to detect certain kinds of usage where we suspect that
people are using PeerConnection for fingerprinting or VPN-detection.

BUG= 685950 

Review-Url: https://codereview.chromium.org/2476323002
Cr-Commit-Position: refs/heads/master@{#446936}
(cherry picked from commit f766db29b990d87a3933a27079c2cf14f09aa4b7)

Review-Url: https://codereview.chromium.org/2681903002 .
Cr-Commit-Position: refs/branch-heads/2987@{#364}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/fea3fead2754330f7d7566d7fca4602342b6355f/third_party/WebKit/Source/core/frame/HostsUsingFeatures.cpp
[modify] https://crrev.com/fea3fead2754330f7d7566d7fca4602342b6355f/third_party/WebKit/Source/core/frame/HostsUsingFeatures.h
[modify] https://crrev.com/fea3fead2754330f7d7566d7fca4602342b6355f/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/fea3fead2754330f7d7566d7fca4602342b6355f/tools/metrics/rappor/rappor.xml

Comment 7 by hta@chromium.org, Apr 5 2017

Status: Fixed (was: Started)
Metric landed. Closing issue.

Sign in to add a comment