New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685949 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression: URL's appearing differently in chrome://md-settings/content/images".

Reported by lpa...@etouch.net, Jan 27 2017

Issue description

Chrome Version: 57.0.2987.11 (Official Build) 4c3e41b7da105a0c0e7951b00f3b56f0bc15814c-refs/branch-heads/2987@{#98} (32/64 Bit)
OS: Mac(10.11.6, 10.12.1, 10.12), Windows(7,8,8.1,10), Linux (14.04 LTS)

Test URL: http://giphy.com/

Steps to reproduce:
1. Launch Chrome, go to above URL, go to "chrome://md-settings/content/images".
2. Add the above URL to Block Image, navigate to the webpage and refresh.
3. Click on the image block icon in omnibox, select Allow.
4. Navigate to "chrome://md-settings/content/images" and observe the URL in block and allow section.

Actual Result: URL's appearing differently in Allow and Block.
Expected Result: URL should appear same.

This is regression issue broken in 'M 56' and will soon update the bisect info:

Manual Bisect Info: 
Good Build 56.0.2917.0
Bad Build 56.0.2918.0 

Note: This issue does not appear when allow permission is given from "chrome://md-settings/content/images".

 
Actual Result.mp4
1.1 MB View Download
Expected Result.mp4
1.2 MB View Download
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Please find the below per-revision bisect information:
Good Build —56.0.2917.0—431726
Bad Build ——56.0.2918.0 —431795

Bisect Tool Info:
----------------
You are probably looking for a change made after 431735 (known good), but no later than 431736 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/fb416fc8cea1442a3eae4d81b17ea310d75a0d99..c03ac1f988225abce504a023f29db90c6dbb2872

Review-Url: https://codereview.chromium.org/2494943003

dschuyler@ Could you please take a look at this issue.

Thank you!
It looks like users are no longer able to enter a block side that doesn't have the [*.] prefix. The [*.] appears to be added automatically, which the old options did not do.
Status: Started (was: Assigned)
CL 2682023002
Blocking: 671375
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/280885a8ab97723e5f1c4bb6f9fdb1bda1418b2a

commit 280885a8ab97723e5f1c4bb6f9fdb1bda1418b2a
Author: dschuyler <dschuyler@chromium.org>
Date: Wed Feb 08 22:35:12 2017

[MD settings] allow site exceptions without pattern wildcard

This CL removes the automatic addition of a '[*.]' prefix when entering
content site exceptions. So if the user entered 'google.com' it was
automatically being promoted to '[*.]google.com'. This CL removes that
automatic promotion/alteration of what user entered.

BUG= 685949 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2682023002
Cr-Commit-Position: refs/heads/master@{#449112}

[modify] https://crrev.com/280885a8ab97723e5f1c4bb6f9fdb1bda1418b2a/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/280885a8ab97723e5f1c4bb6f9fdb1bda1418b2a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Status: Fixed (was: Started)
The fix makes the new settings behave the same as the old options page in this area.
(chrome://settings/contentExceptions#images)
For example: blocking wikipedia.org will not block images on the wikipedia home page because www.wikipedia.org (or [*.]wikipedia.org) is needed to block that page. This is true on the old options and the new settings now (with the CL above) match that behavior.
Example 2: if www.wikipedia.org is blocked by entering the value in options or settings and then set to allowed with the Omnibox icon (as demo'ed in this bug), the block on www.wikipedia.org will remain and an https://www.wikipedia.org:443 will be added as allowed. This happens in the old options and the new settings.

Sign in to add a comment