New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685935 link

Starred by 2 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dbeam@chromium.org
█ msrchandra@chromium.org
bettes@chromium.org
█ ranjitkan@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [MD Settings]Unnecessary blue ring appears after clicking on 'Use current page' button.

Reported by dchau...@etouch.net, Jan 27 2017 
Chrome Version: 58.0.2994.0 (Official Build)11048b2f4c969c558eb594f4500b14d4c250d9e4-refs/heads/master@{#446546} 32/64-bit.
OS: Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings page.
2. Select radio button of "Open a specific page or set of pages" under 'On startup' section.
3. Now, click on 'Use current page' button and observe.

Unnecessary blue ring appears after clicking on it.
No such blue ring should appears after clicking on it.

This is a regression issue, broken in M-58 series, will soon update other info.

Comment 1 by dchau...@etouch.net, Jan 27 2017 

Below is manual regression range.

Good build: 58.0.2993.0
Bad build: 58.0.2994.0

Note: Will soon update the behavior of Mac and Linux OS, once builds are available.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
668 KB View Download
Expected behavior.mp4
482 KB View Download

Comment 2 by rbasuvula@chromium.org, Jan 27 2017

Cc: rbasuvula@chromium.org
 Issue 685941  has been merged into this issue.

Comment 3 by rbasuvula@chromium.org, Jan 27 2017

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: scottchen@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.2993.0 (Revision: 446204).
Bad build: 58.0.2994.0 (Revision: 446546).

You are probably looking for a change made after 446235 (known good), but no later than 446236 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/2fbc5bb6bdc66f31173fab53372c69a97c39eccb..a41c7aae93287688ee2e3b345b46d70b1e5f8e4b

From the CL above, assigning the issue to the concern owner

@Scottchen : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2639373002

Note : Able to reproduce the issue in Win 7,Ubuntu 14.04 & Mac 10.12.2.

Comment 4 Deleted

Comment 5 by scottchen@chromium.org, Jan 30 2017

Cc: dbeam@chromium.org bettes@chromium.org hcarmona@chromium.org
dbeam@ bettes@ can you guys give some input on what should happen here, including when this button's clicked by the mouse vs. focused by keyboard and pressed enter? Not too sure that the focus should just go away.
(I spoke to hcarmona@ and he suggested that I get your opinions).

Comment 6 by dbeam@chromium.org, Jan 31 2017

Status: WontFix (was: Assigned)
the old version WITHOUT a focus outline was a bug

new version WITH a focus outline is not

we might want to tweak the outline spacing in the future, though.

Comment 7 by dbeam@chromium.org, Jan 31 2017

Status: Assigned (was: WontFix)
sorry, neither <a href> nor <a is="action-link"> should show a focus outline on mousedown

Comment 8 by scottchen@chromium.org, Feb 1 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment