Issue metadata
Sign in to add a comment
|
More aggressive popup blocking |
||||||||||||||||||||||||||
Issue descriptionThings I recall we discussed: * Shift popup blocker options to basically "prevent any popups for any reason" vs. "allow a single popup on click" (may require checking UMA stats for existing "allow" usage). Thought: perhaps in either of these cases adding a whitelisted site should let it show popups without a click, so that "whitelist this site for your popup blocker" still works? * Close holes with Flash-triggered popups. Almost any porn site (e.g. YouPorn) is a good testcase for popups, they seem to like to open popups on the first click of any specific video's page.
,
Jan 27 2017
Incidentally, since you used the word "adding" -- I suspect if we try to turn popup blocking into a three-state setup we're going to stall, and personally I think we would do well to stick with two states, where one of the two is "never show popups, not even on gesture" and the other is whatever. Not sure what "adding" was intended to convey, so just throwing that out there :) Also, if the Flash-triggered stuff should be forked off to its own bug, please feel free to do so -- I don't know exactly what the state of the world there is, only that Jochen says there are improvements that could be made but haven't been due to test coverage.
,
Jan 27 2017
Ah, okay. So like this: - Allow - Default (current "Block" behaviour == allow 1 per user gesture, else block and show page action) - Block (block alllllllllll) That was how I had *assumed* this worked until you pointed out otherwise last night. That sounds fine to me. Sydney folks/Emily: How much research/approval do we need for a change like that?
,
Jan 28 2017
Uh... are we talking past each other? I was saying that we should try and stick with two states, whatever we do (in your labels, "block" + either "default" or "allow"). And "block" should be default.
,
Jan 28 2017
Right, I'd suggest to go for "block all popups whatsoever (default)" and "allow popups with user gesture" as opposed to currently "allow all popups" and "allow popups with user gesture (default)"
,
Jan 28 2017
Apparently we were. I presume some use cases require popups without user gestures. I've certainly seen Chrome experiments that require it.
,
Jan 28 2017
that's like the only case I know of.
,
Jan 28 2017
That's why I said in my first comment "perhaps in either of these cases adding a whitelisted site should let it show popups without a click". In other words, under the hood there are actually the three states you describe, and if you make an "allow" exception, it means "fully allow", even if that isn't one of the choices we give you for the global setting.
,
Feb 3 2017
I'm a bit confused -- @jochen would you be able to clear up what the current behaviour is? I know there is a way for users to block and allow popups, and there is also a default state, but somehow this maps to only two Content Settings?
,
Feb 3 2017
Also to answer #1, we only added popup metrics in M57 so it will be a while before we have numbers.
,
Feb 10 2017
,
Feb 12 2017
Removing myself as owner since this is a duplicate. |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Jan 27 2017Components: Internals>Permissions>Model
Owner: kcaratt...@chromium.org
Status: Assigned (was: Untriaged)