New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685905 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Include referrer chain with inline install requests.

Project Member Reported by robertshield@chromium.org, Jan 27 2017

Issue description

Extension inline install requests should include the referrer chain when sending a ping to the webstore. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59

commit 1fc1a4a7f6d66e0e8afad18258fc478e9b151d59
Author: robertshield <robertshield@chromium.org>
Date: Wed Feb 01 15:18:33 2017

Include referrer chain with inline install requests.

BUG= 685905 

Review-Url: https://codereview.chromium.org/2655823002
Cr-Commit-Position: refs/heads/master@{#447515}

[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_data_fetcher.cc
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_data_fetcher.h
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_inline_installer.cc
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_inline_installer.h
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_installer_test.cc
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_installer_test.h
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_standalone_installer.cc
[modify] https://crrev.com/1fc1a4a7f6d66e0e8afad18258fc478e9b151d59/chrome/browser/extensions/webstore_standalone_installer.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7

commit 9fb1c8b9feec6f43c99eca8cecf09a5582c254f7
Author: sky <sky@chromium.org>
Date: Mon May 01 23:57:02 2017

Revert of Use new SafeBrowsing redirect tracking code in CWS pings. (patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ )

Reason for revert:
Reverting in hopes of fixing 717315. See it for details.

Original issue's description:
> Use new SafeBrowsing redirect tracking code in CWS pings.
>
> The SafeBrowsing code tracks more types of redirects than the /net code which strictly adheres to spec and so can drop various types of redirects which can obscure the referrer chain.
>
> BUG= 685905 
>
> Review-Url: https://codereview.chromium.org/2779643002
> Cr-Commit-Position: refs/heads/master@{#468389}
> Committed: https://chromium.googlesource.com/chromium/src/+/39d1ffe7ba2c6fc8ebe6245472e0191b6f29aa9c

TBR=jialiul@chromium.org,rdevlin.cronin@chromium.org,robertshield@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 685905 

Review-Url: https://codereview.chromium.org/2854763002
Cr-Commit-Position: refs/heads/master@{#468495}

[modify] https://crrev.com/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7/chrome/browser/extensions/webstore_inline_installer.cc
[modify] https://crrev.com/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7/chrome/browser/extensions/webstore_inline_installer.h
[modify] https://crrev.com/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2017

Sign in to add a comment