Include referrer chain with inline install requests. |
||
Issue descriptionExtension inline install requests should include the referrer chain when sending a ping to the webstore.
,
Mar 20 2017
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7 commit 9fb1c8b9feec6f43c99eca8cecf09a5582c254f7 Author: sky <sky@chromium.org> Date: Mon May 01 23:57:02 2017 Revert of Use new SafeBrowsing redirect tracking code in CWS pings. (patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ ) Reason for revert: Reverting in hopes of fixing 717315. See it for details. Original issue's description: > Use new SafeBrowsing redirect tracking code in CWS pings. > > The SafeBrowsing code tracks more types of redirects than the /net code which strictly adheres to spec and so can drop various types of redirects which can obscure the referrer chain. > > BUG= 685905 > > Review-Url: https://codereview.chromium.org/2779643002 > Cr-Commit-Position: refs/heads/master@{#468389} > Committed: https://chromium.googlesource.com/chromium/src/+/39d1ffe7ba2c6fc8ebe6245472e0191b6f29aa9c TBR=jialiul@chromium.org,rdevlin.cronin@chromium.org,robertshield@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 685905 Review-Url: https://codereview.chromium.org/2854763002 Cr-Commit-Position: refs/heads/master@{#468495} [modify] https://crrev.com/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7/chrome/browser/extensions/webstore_inline_installer.cc [modify] https://crrev.com/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7/chrome/browser/extensions/webstore_inline_installer.h [modify] https://crrev.com/9fb1c8b9feec6f43c99eca8cecf09a5582c254f7/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1547f4c5289b094a0d0487e6c54297cede4d5db7 commit 1547f4c5289b094a0d0487e6c54297cede4d5db7 Author: robertshield <robertshield@chromium.org> Date: Wed May 03 16:53:17 2017 Reland "Use new SafeBrowsing redirect tracking code in CWS pings."" (patchset #6 id:140001 of https://codereview.chromium.org/2779643002/ ) This reverts commit 9fb1c8b9feec6f43c99eca8cecf09a5582c254f7. It relands the original patch by fixing an uninitialized read in the related browser test. BUG= 685905 , 717315 Review-Url: https://codereview.chromium.org/2857663002 Cr-Commit-Position: refs/heads/master@{#469006} [modify] https://crrev.com/1547f4c5289b094a0d0487e6c54297cede4d5db7/chrome/browser/extensions/webstore_inline_installer.cc [modify] https://crrev.com/1547f4c5289b094a0d0487e6c54297cede4d5db7/chrome/browser/extensions/webstore_inline_installer.h [modify] https://crrev.com/1547f4c5289b094a0d0487e6c54297cede4d5db7/chrome/browser/extensions/webstore_inline_installer_browsertest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 1 2017