webports: add a secureshell branch |
|||||
Issue descriptionhttps://chromium-review.googlesource.com/#/admin/projects/webports,branches can we have a new branch created in the webports repo ? branch name: secureshell starting git sha1: feabf015fa87420ae670056709f32972b4d4acf6 https://chromium-review.googlesource.com/#/admin/projects/webports,access then can we give access to it for people in the "apps-committers" group ? the SecureShell extension is more or less suck on the nacl v35 toolchain which means we're stuck on an old webports version, but we need to land some package updates (like openssl & zlib)
,
Jan 31 2017
i chatted with bradnelson@ via hangouts at the time and he said he was fine with the idea. can't comment wrt their preferences for admin requests like this though :).
,
Jan 31 2017
Sad that we are stuck there :( Any chance that will ever change? But given that we are.... sgtm. Done.
,
Jan 31 2017
,
Jan 31 2017
,
Jan 31 2017
when i say "we're stuck on v35", what i mean is: * we've tried to upgrade to newer versions like v47+, but the resulting builds of openssh are unreliable/flaky and crash at weird places. reverting back to v35 and all the problems go away. * considering the future of (P)NaCl (i.e. everything is going to web assembly and (P)NaCl is going away), it isn't worth anyone's time to investigate these problems. * i'm pretty sure there are no advantages to us using a newer toolchain wrt security/stability/optimization here. we've got a great sandbox already regardless of the version, and the performance appears to be sufficient (all the bottlenecks are in the HTML/JS side of things with rendering). * SecureShell only cares about 3 packages: glibc-compat, zlib, openssl. i can handle updates of those myself since i'm already a maintainer for glibc/zlib/openssl in CrOS & Gentoo (and have worked with upstream for all three). so once webasm becomes a reality we can use, we'll most likely look to jump ship from (P)NaCl entirely.
,
Feb 1 2017
the branch is created, but the ACLs aren't set up to allow us to push CLs through for this branch. the idea as to let us self-serve on this w/out hassling you, or do you guys want us to send these old ones to you too ?
,
Feb 1 2017
I'll let binji/bradnelson/sbc answer that question.
,
Feb 1 2017
What permissions do you need exactly? Do you want to be able to push directly to that branch? If the changes are few I think going through code review is still probably a good idea? At least perhaps at first?
,
Feb 1 2017
push would be nice ;), but just the ability to Code-Review/Commit-Queue/Submit CLs ourselves is sufficient. we were planning on doing code review, but against ourselves. if you want, i can add you guys to my CLs.
,
Feb 1 2017
reviewing yourselves sounds fine. Not sure if that means you need to be added naclports-committers, it might just work as it stands.
,
Feb 1 2017
Added vapier@ and rginda@ to naclports-committers
,
Feb 1 2017
adding me/rginda@ to naclports-committers would work as well. i just figured adding an exception for refs/heads/secureshell would keep us from stomping on master by accident. if you aren't worried about that, then sure, let's go that route :).
,
Feb 1 2017
Looks like that gives to "push" and "Submit" (if i'm reading the ACL stuff correctly).
,
Feb 1 2017
The CQ has not been used in the long time, and never on a branch, so you might not want to use that :(
,
Feb 1 2017
it does indeed ;). but my plan was to go the gerrit/review route (assuming it works out).
,
Feb 14 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by aga...@chromium.org
, Jan 31 2017