FTR AccessibilityPopupView looks to be shown when ChromeVox or Braille input is enabled with a keyboard shortcut (ctrl+alt+z). This message of "ChromeVox is enabled, use ctrl+alt+z to disable" is what can instead be sent to the notification center.

I don't think this is on fukino@'s radar to fix any time soon (please correct me if I am mistaken) so estade@ and stevenjb@ feel free to poach if interested.

Right. I haven't started yet. Please feel free to take!

I think +yiyix@ expressed some interest in this, depending on spare cycles.

I can happily take this task. 
After moving sms from notification view to the notification center, I was able to remove lots of notification view related code as shown in this cl: https://codereview.chromium.org/2583393002/

I am happy to move a11y messages into the notification center and completely remove the notification view. 

I finished the prototype for this bug. I need some clarification to finish it:
- This notification is used be to shown in the notification view and it is auto-closed after 5 seconds. Now the notification auto-hides after few seconds. Is it good enough? or we still need to close it?

- Do we need a title to this notification? or it is good enough.

Thank you for clarification

Deleted: Screenshot from 2017-03-07 17:45:51.png 15.0 KB

	Screenshot from 2017-03-07 17:45:51.png 15.0 KB View Download

In this new implementation, the notification will be auto-closed if the setting on "spoken feedback" or "braille display connected" is changed. 

I'd suggest:

title: ChromeVox enabled
message: Spoken feedback is enabled. Press...

Also, attached is a related notification. It seems like we should match the icon between these two notifications.

Deleted: TCz4JfpoKqq.png 11.1 KB

	TCz4JfpoKqq.png 11.1 KB View Download

+sgabriel for feedback on #14-#16

Title looks good but what do you mean by icon should match? color wise ? If so yes it should be colored like the keyboard.

@sgabriel I think Evan is talking to me. In my screenshot, I used the accessibility icon instead of the spoken feedback icon. 

I can update the title, icon and the text. Do you prefer the icon to be be grey or yellow? Any other suggestions?

#5a5a5a for the icon color. Thanks!

What I meant was that imo the icon itself should be the same for "ChromeVox Updated" and "ChromeVox Enabled". Whether that's the generic a11y icon or the screen reader one is Sebastien's call. I didn't mean to imply you had to fix it right away, but we should be conscious of this discrepancy and fix it at some point.

That makes sense, icon should be the same and it should be the screen reader one.

so the orange chromevox icons (different sizes) live here and I'm not sure all the places they're used: chrome/browser/resources/chromeos/chromevox/images/

Attached is the svg we can use to make a .icon file. Sebastien, lgty modulo color?

Deleted: chromevox.svg 1.4 KB

chromevox.svg 1.4 KB Download

The other notification view message is "Braille display connected.". would the keyboard icon be a good choice for this one?

I created new icons for both ChromeVox and Braille. See attached. They are both sized based on the current notification spec (40x40). Please use them colored #5a5a5a.

Deleted: chromevox+braille.zip 2.3 KB

chromevox+braille.zip 2.3 KB Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673de101a2b30b905462441b12828a83f85d02d7

commit 673de101a2b30b905462441b12828a83f85d02d7
Author: tdanderson <tdanderson@chromium.org>
Date: Mon Apr 03 19:58:36 2017

[Ash] Fold TrayNotificationView into AccessibilityPopupView

AccessibilityPopupView is now the only subclass of
TrayNotificationView, so fold the latter into the former.
This CL also removes the now-unused PNG asset for
the a11y icon.

BUG= 686217 , 685845 
TEST=manual
TBR=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2785273002
Cr-Commit-Position: refs/heads/master@{#461512}

[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/BUILD.gn
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/common/system/tray/tray_notification_view.cc
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/common/system/tray/tray_notification_view.h
[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/common/system/tray_accessibility.h
[modify] https://crrev.com/673de101a2b30b905462441b12828a83f85d02d7/ash/resources/ash_resources.grd
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/resources/default_100_percent/cros/status/status_accessibility_dark.png
[delete] https://crrev.com/afb25842158a4bad4c7e61dfc0b1c48223f9d351/ash/resources/default_200_percent/cros/status/status_accessibility_dark.png

There is a third case: If the spoken feedback is not enabled and a braille is connected, then both the braille and spoken feedback will be enabled at the same time. The popup is used to be : "Braille display connected. Spoken feedback is enabled.\nPress Ctrl+Alt+Z to disable." 

@sgabriel which icon do you suggest to use for this notification?

@sgabriel and I have resolved offline. 

Use the accessibility log and set the text as:
title: Braille and Chromevox are enabled
text: Press Ctrl + Alt + Z to disable spoken feedback.

I will update the notification pictures here later.

@sgabriel: I attached all notification at both 1x and 2x device factor. I feel that the notification for braille connection might be too short, but there is no additional information to be added..... Thank you feedbacks

Deleted: Screenshot from 2017-05-08 01_19_51.png 14.6 KB

	Screenshot from 2017-05-08 01_19_51.png 14.6 KB View Download

Deleted: Screenshot from 2017-05-08 01_18_14.png 5.8 KB

	Screenshot from 2017-05-08 01_18_14.png 5.8 KB View Download

Deleted: Screenshot from 2017-05-08 01_24_18.png 6.9 KB

	Screenshot from 2017-05-08 01_24_18.png 6.9 KB View Download

Deleted: Screenshot from 2017-05-08 01_23_35.png 3.0 KB

	Screenshot from 2017-05-08 01_23_35.png 3.0 KB View Download

Deleted: Screenshot from 2017-05-08 01_29_11.png 13.9 KB

	Screenshot from 2017-05-08 01_29_11.png 13.9 KB View Download

Deleted: Screenshot from 2017-05-08 01_28_39.png 5.3 KB

	Screenshot from 2017-05-08 01_28_39.png 5.3 KB View Download

It feels a bit short for sure but there's no need to add text just to fill it. 

Can we adjust the layout though?

I'm working on that but this is using the default template as far as I know. 
We shouldn't special case it.

@yiyix, it doesn't look like you are using Title but content for the single lined Braille, can you check?

It's correct, I used content instead of tile for braille. By looking through code, I think it's more common to have notification without title. I can use title instead. @estade, i found that a notification is defined with minimum height and width. 
const int kNotificationWidth = 360;
const int kMinScrollViewHeight = 77;

I am not sure if i can easily modify the style.

Sorry, i forget to upload the picture after setting "braille is connected" as title. 

Deleted: Screenshot from 2017-05-08 13_38_26.png 3.3 KB

	Screenshot from 2017-05-08 13_38_26.png 3.3 KB View Download

Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df25af11bbad658a261076cef020590b9988f9b

commit 2df25af11bbad658a261076cef020590b9988f9b
Author: yiyix <yiyix@chromium.org>
Date: Tue May 23 16:51:07 2017

Add accessibility related notification into notification center

When chromevox is enabled or the braille is connected, a notification will be shown to
users through the notification center. The screenshot of the notifications can be found
in the crbug.

TEST=TrayAccessibilityTest.ShowNotification

BUG= 685845 

Review-Url: https://codereview.chromium.org/2838903002
Cr-Commit-Position: refs/heads/master@{#473939}

[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/ash_strings.grd
[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/metrics/user_metrics_action.h
[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/resources/vector_icons/BUILD.gn
[add] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/resources/vector_icons/notification_accessibility_braille.icon
[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/system/tray_accessibility.cc
[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/ash/system/tray_accessibility.h
[modify] https://crrev.com/2df25af11bbad658a261076cef020590b9988f9b/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Yi, is there anything left to do for this bug?

all done. Update status.