Which OSs does this affect?

All OSes

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f

commit c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f
Author: caseq <caseq@chromium.org>
Date: Wed Feb 01 21:23:21 2017

DevTools: fix flame chart on profiler pane

This also includes a stub for FlameChart smoke tests.

BUG= 685838 

Review-Url: https://codereview.chromium.org/2654253004
Cr-Commit-Position: refs/heads/master@{#447612}

[add] https://crrev.com/c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f/third_party/WebKit/LayoutTests/inspector/components/flame-chart-expected.txt
[add] https://crrev.com/c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f/third_party/WebKit/LayoutTests/inspector/components/flame-chart.html
[modify] https://crrev.com/c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

A friendly reminder that M57 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Confirmed on 57.0.2987.21 beta Ubuntu 16.04 too. I can't ever open a profile (assuming it actually made profiling results??)

perf_ui_module.js:229 Uncaught TypeError: Cannot read property 'startLevel' of undefined
    at PerfUI.FlameChart._updateLevelPositions (perf_ui_module.js:229)
    at PerfUI.FlameChart._processTimelineData (perf_ui_module.js:228)
    at PerfUI.FlameChart._timelineData (perf_ui_module.js:116)
    at PerfUI.FlameChart.update (perf_ui_module.js:255)
    at Profiler.CPUProfileFlameChart.update (profiler_module.js:380)
    at Profiler.CPUProfileView.initialize (profiler_module.js:152)
    at new Profiler.CPUProfileView (profiler_module.js:414)
    at Profiler.CPUProfileHeader.createView (profiler_module.js:439)
    at Profiler.HeapProfilerPanel.viewForProfile (profiler_module.js:99)
    at Profiler.HeapProfilerPanel.showProfile (profiler_module.js:94)

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcf0be98f2727760b2b3acbfd06b0c69e55eb3ad

commit bcf0be98f2727760b2b3acbfd06b0c69e55eb3ad
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Thu Feb 09 00:07:07 2017

DevTools: fix flame chart on profiler pane

This also includes a stub for FlameChart smoke tests.

BUG= 685838 

Review-Url: https://codereview.chromium.org/2654253004
Cr-Commit-Position: refs/heads/master@{#447612}
(cherry picked from commit c84d488aa22e7c9a660b2c8f84a9a7edcc9a7e3f)

Review-Url: https://codereview.chromium.org/2680353003 .
Cr-Commit-Position: refs/branch-heads/2987@{#398}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[add] https://crrev.com/bcf0be98f2727760b2b3acbfd06b0c69e55eb3ad/third_party/WebKit/LayoutTests/inspector/components/flame-chart-expected.txt
[add] https://crrev.com/bcf0be98f2727760b2b3acbfd06b0c69e55eb3ad/third_party/WebKit/LayoutTests/inspector/components/flame-chart.html
[modify] https://crrev.com/bcf0be98f2727760b2b3acbfd06b0c69e55eb3ad/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Tested on windows 7, mac os 10.12.2 using chrome M57 #57.0.2987.54 and observed no error message on console after the profile loading.

Followed steps :
1. Opened DevTools, switched to Profiles 
2. Recorded CPU profile
3. Switched to Chart view and checked console .

Attached screencast for reference.

@caseq-- Could you please let us know if this is the expected behavior or if we had missed out any steps in reproducing the issue .

Thanks!

Deleted: 685838.mp4 442 KB

	685838.mp4 442 KB View Download

I'd say this looks plausible considering lack of JS activity on the given page. Don't other versions look the same on this scenario? You may want to try it on something more JS heave (pretty much any real page, e.g. try theverge.com)

Thank caseq@, Verified the issue with Chrome version 57.0.2987.54 on Windows 7,10, Mac and Linux.


Steps followed :
1. launch Chrome and visit theverge.com
2. Opened DevTools, switched to Profiles 
2. Recorded CPU profile
3. Switch to Chart view and checked console

Observed behavior :
Flame chart is working

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

caseq@ Could you please confirm the comment #13 steps is the right way to verify  this issue?

Thanks!

Please mark as fixed if there is no pending work here. Thank you.