New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685837 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Remove all non-MD test coverage in Ash native UI

Project Member Reported by tdander...@chromium.org, Jan 26 2017

Issue description

Remove all test coverage which exercises the non-MD code paths in Ash native UI (system menu, shelf, etc). The following files will need to be changed (I believe the list is complete):

ash/common/system/chromeos/power/power_status_unittest.cc
ash/common/system/chromeos/power/power_status_view_unittest.cc
ash/common/system/ime/tray_ime_chromeos_unittest.cc
ash/common/system/tray/system_tray_unittest.cc
ash/common/system/tray/tray_details_view_unittest.cc
ash/common/system/user/tray_user_unittest.cc
ash/dip_unittest.cc
ash/display/display_manager_unittest.cc
ash/display/window_tree_host_manager_unittest.cc
ash/root_window_controller_unittest.cc
ash/screen_util_unittest.cc
ash/shelf/shelf_layout_manager_unittest.cc
ash/shelf/shelf_view_unittest.cc
ash/shelf/shelf_widget_unittest.cc
ash/system/web_notification/web_notification_tray_unittest.cc
ash/wm/drag_window_resizer_unittest.cc
ash/wm/window_positioner_unittest.cc
ash/wm/window_state_unittest.cc
ash/wm/workspace_controller_unittest.cc
ash/wm/workspace/workspace_window_resizer_unittest.cc
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
chrome/browser/chromeos/shutdown_policy_browsertest.cc
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc


Furthermore, remove any unnecessary code that tracks MD flag state inside of test fixtures or helpers, e.g., AshTestHelper::SetUp().
 
Cc: est...@chromium.org
FYI this can be done immediately (no need to wait until 56 hits stable) in case you're interested.
Owner: moh...@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Labels: Hotlist-CodeHealth
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1fbe08e33f617ef153c305b2af58e2f130767b2

commit f1fbe08e33f617ef153c305b2af58e2f130767b2
Author: mohsen <mohsen@chromium.org>
Date: Wed Feb 08 02:07:13 2017

Remove non-MD test coverage from SystemTrayTest

Test coverage for touch feedback and settings row are removed.

BUG= 685837 
TEST=SystemTrayTest.* in ash_unittests

Review-Url: https://codereview.chromium.org/2678343006
Cr-Commit-Position: refs/heads/master@{#448853}

[modify] https://crrev.com/f1fbe08e33f617ef153c305b2af58e2f130767b2/ash/common/system/tray/system_tray_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62b316ce3138b7db046f25cf0d7cd7f5901dcf5

commit c62b316ce3138b7db046f25cf0d7cd7f5901dcf5
Author: mohsen <mohsen@chromium.org>
Date: Wed Feb 08 02:10:46 2017

Remove non-MD test coverage from TrayUserTest

Removed test coverage for the separator that only exists in non-MD
TrayUser.

BUG= 685837 
TEST=TrayUserTest.* in ash_unittests

Review-Url: https://codereview.chromium.org/2680993002
Cr-Commit-Position: refs/heads/master@{#448856}

[modify] https://crrev.com/c62b316ce3138b7db046f25cf0d7cd7f5901dcf5/ash/common/system/user/tray_user_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/096fa853801729da981d17b5346698acb4cca48e

commit 096fa853801729da981d17b5346698acb4cca48e
Author: mohsen <mohsen@chromium.org>
Date: Wed Feb 08 02:44:54 2017

Enable tests in TrayIMETest for MD

All three tests in TrayIMETest are skipped in Material Design Ash which
is now the default. Two of the tests would work as-is in MD. The other
one needs some modification as it depends on the IME tray layout.

Also, since a TestApi class is introduced for ImeListView, other tests
that need access to the internals of the ImeListView are also updated.

BUG= 685837 
TEST=TrayIMETest.*, ImeMenuTrayTest.RefreshImeWithListViewCreated in
     ash_unittests

Review-Url: https://codereview.chromium.org/2686623003
Cr-Commit-Position: refs/heads/master@{#448872}

[modify] https://crrev.com/096fa853801729da981d17b5346698acb4cca48e/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/096fa853801729da981d17b5346698acb4cca48e/ash/common/system/chromeos/ime_menu/ime_list_view.h
[modify] https://crrev.com/096fa853801729da981d17b5346698acb4cca48e/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/096fa853801729da981d17b5346698acb4cca48e/ash/common/system/ime/tray_ime_chromeos_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2254cd2051623bbe445fd16da8aabcb16d37b0f4

commit 2254cd2051623bbe445fd16da8aabcb16d37b0f4
Author: mohsen <mohsen@chromium.org>
Date: Thu Feb 09 05:01:31 2017

Remove non-MD test coverage from TrayDetailsViewTest

Test coverage for touch feedback is removed. Also, some tests that
checked non-MD version of TrayDetailsView are updaed.

BUG= 685837 
TEST=TrayDetailsViewTest.* in ash_unittests

Review-Url: https://codereview.chromium.org/2681963002
Cr-Commit-Position: refs/heads/master@{#449203}

[modify] https://crrev.com/2254cd2051623bbe445fd16da8aabcb16d37b0f4/ash/common/system/tray/tray_details_view_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58067513307e4ab9d0bd473670cf3fa883aa0f6a

commit 58067513307e4ab9d0bd473670cf3fa883aa0f6a
Author: mohsen <mohsen@chromium.org>
Date: Thu Feb 09 16:57:22 2017

Remove non-MD test coverage form ShelfViewTest and subclasses

Removed touch feedback tests from ShelfViewTest as it is a non-MD
feature. Also removed forcing EXPERIMENTAL mode in ShelfViewInkDropTest
and its subclasses as ink drop is graduated out of experimental; and
material mode is on by default.

BUG= 685837 
TEST=ShelfViewTest.*, ShelfViewInkDropTest.*, OverflowButtonInkDropTest.*,
     OverflowButtonActiveInkDropTest.* in ash_unittests

Review-Url: https://codereview.chromium.org/2686883003
Cr-Commit-Position: refs/heads/master@{#449323}

[modify] https://crrev.com/58067513307e4ab9d0bd473670cf3fa883aa0f6a/ash/shelf/shelf_view_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6faf4f3fb65efc226192ee426018dbfce4dc1a89

commit 6faf4f3fb65efc226192ee426018dbfce4dc1a89
Author: mohsen <mohsen@chromium.org>
Date: Thu Feb 09 22:09:41 2017

Remove non-MD test coverage from tests in chrome/browser/chromeos/

Now that Material Design mode for Ash is on by default, we can remove
non-MD test coverages.

BUG= 685837 
TEST=SpokenFeedbackTest.* in interactive_ui_tests,
     SystemUse24HourClockPolicyTest.*, ShutdownPolicyInSessionTest.*,
     TrayAccessibilityTest.* in browser_tests

Review-Url: https://codereview.chromium.org/2682393004
Cr-Commit-Position: refs/heads/master@{#449435}

[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6faf4f3fb65efc226192ee426018dbfce4dc1a89

commit 6faf4f3fb65efc226192ee426018dbfce4dc1a89
Author: mohsen <mohsen@chromium.org>
Date: Thu Feb 09 22:09:41 2017

Remove non-MD test coverage from tests in chrome/browser/chromeos/

Now that Material Design mode for Ash is on by default, we can remove
non-MD test coverages.

BUG= 685837 
TEST=SpokenFeedbackTest.* in interactive_ui_tests,
     SystemUse24HourClockPolicyTest.*, ShutdownPolicyInSessionTest.*,
     TrayAccessibilityTest.* in browser_tests

Review-Url: https://codereview.chromium.org/2682393004
Cr-Commit-Position: refs/heads/master@{#449435}

[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6faf4f3fb65efc226192ee426018dbfce4dc1a89

commit 6faf4f3fb65efc226192ee426018dbfce4dc1a89
Author: mohsen <mohsen@chromium.org>
Date: Thu Feb 09 22:09:41 2017

Remove non-MD test coverage from tests in chrome/browser/chromeos/

Now that Material Design mode for Ash is on by default, we can remove
non-MD test coverages.

BUG= 685837 
TEST=SpokenFeedbackTest.* in interactive_ui_tests,
     SystemUse24HourClockPolicyTest.*, ShutdownPolicyInSessionTest.*,
     TrayAccessibilityTest.* in browser_tests

Review-Url: https://codereview.chromium.org/2682393004
Cr-Commit-Position: refs/heads/master@{#449435}

[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/6faf4f3fb65efc226192ee426018dbfce4dc1a89/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84069f265a506df8b66ab1109aa0a576f086b971

commit 84069f265a506df8b66ab1109aa0a576f086b971
Author: mohsen <mohsen@chromium.org>
Date: Fri Feb 10 02:22:20 2017

Remove non-MD test coverage from ShelfLayoutManagerTest

Removed checks that verify some non-MD immersive mode layout.

BUG= 685837 
TEST=ShelfLayoutManagerTest.* in ash_unittests

Review-Url: https://codereview.chromium.org/2683033002
Cr-Commit-Position: refs/heads/master@{#449520}

[modify] https://crrev.com/84069f265a506df8b66ab1109aa0a576f086b971/ash/shelf/shelf_layout_manager_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97f5c688fee9e12927c7deed091350fbe27f531f

commit 97f5c688fee9e12927c7deed091350fbe27f531f
Author: mohsen <mohsen@chromium.org>
Date: Fri Feb 10 02:24:39 2017

Remove non-MD test coverage from chrome/browser/ui/

Now that Material Design mode for Ash is on by default, we can remove
non-MD test coverage.

BUG= 685837 
TEST=SystemTrayDelegateChromeOSTest.*,
     BrowserNonClientFrameViewAshTest.* in browser_tests,
     ImmersiveModeControllerAshTest.* in unit_tests

Review-Url: https://codereview.chromium.org/2683313002
Cr-Commit-Position: refs/heads/master@{#449522}

[modify] https://crrev.com/97f5c688fee9e12927c7deed091350fbe27f531f/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[modify] https://crrev.com/97f5c688fee9e12927c7deed091350fbe27f531f/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/97f5c688fee9e12927c7deed091350fbe27f531f/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a23d6ceb29374e303c7bfd356c4455fde45ca208

commit a23d6ceb29374e303c7bfd356c4455fde45ca208
Author: estade <estade@chromium.org>
Date: Wed Feb 15 00:47:09 2017

Gut ash::MaterialDesignController, and remove the about:flags entry.

It's not removed completely because IsXXXMaterial() is still used in
many places and serves as a good marker for code cleanup, but it no
longer does anything useful.

A bunch of tests are updated as well to remove parameterization. The
amount of overlap with  bug 685837  was not originally intended, but at a
certain point it became easier to keep removing code than to carefully
determine dependencies.

BUG= 690048 , 685837 

Review-Url: https://codereview.chromium.org/2692663002
Cr-Commit-Position: refs/heads/master@{#450531}

[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/BUILD.gn
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/ash_switches.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/ash_switches.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/material_design/material_design_controller.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/material_design/material_design_controller.h
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/common/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/shelf/shelf_constants.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/chromeos/power/power_status_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/chromeos/power/power_status_view_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/date/system_info_default_view_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/system/tray/tray_constants.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/test/BUILD.gn
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/common/test/material_design_controller_test_api.cc
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/common/test/material_design_controller_test_api.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/dip_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/mus/window_manager_application.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/screen_util_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/BUILD.gn
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/test/ash_md_test_base.cc
[delete] https://crrev.com/1645e63d771e2ee049d465ce70bca163fd9f5bcc/ash/test/ash_md_test_base.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_base.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_base.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_helper.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_helper.h
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/test/ash_test_helper_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/drag_window_resizer_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/window_state_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/app/generated_resources.grd
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/browser/about_flags.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/test/base/browser_with_test_window_test.cc
[modify] https://crrev.com/a23d6ceb29374e303c7bfd356c4455fde45ca208/chrome/test/base/view_event_test_platform_part_chromeos.cc

Comment 16 by warx@chromium.org, Feb 17 2017

Cc: keta...@chromium.org
Labels: Merge-Request-57
merge request for this CL: https://chromium.googlesource.com/chromium/src/+/97f5c688fee9e12927c7deed091350fbe27f531f

This CL is just a test cleanup. It would not hurt to be merged to M57 at all. It will help for merging the CL in  issue 690295 .

Comment 17 by warx@chromium.org, Feb 17 2017

Cc: warx@chromium.org
Project Member

Comment 18 by sheriffbot@chromium.org, Feb 17 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 17 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378cb52e62a84eac09828e59028a20dd37594869

commit 378cb52e62a84eac09828e59028a20dd37594869
Author: Qiang Xu <warx@chromium.org>
Date: Fri Feb 17 00:19:52 2017

[Merge to M57] Remove non-MD test coverage from chrome/browser/ui/

Merge to M57 on behalf of mohsen@

Now that Material Design mode for Ash is on by default, we can remove
non-MD test coverage.

TBR=sky@chromium.org
BUG= 685837 
TEST=SystemTrayDelegateChromeOSTest.*,
     BrowserNonClientFrameViewAshTest.* in browser_tests,
     ImmersiveModeControllerAshTest.* in unit_tests

Review-Url: https://codereview.chromium.org/2683313002
Cr-Commit-Position: refs/heads/master@{#449522}
(cherry picked from commit 97f5c688fee9e12927c7deed091350fbe27f531f)

Review-Url: https://codereview.chromium.org/2702643002 .
Cr-Commit-Position: refs/branch-heads/2987@{#566}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/378cb52e62a84eac09828e59028a20dd37594869/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[modify] https://crrev.com/378cb52e62a84eac09828e59028a20dd37594869/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/378cb52e62a84eac09828e59028a20dd37594869/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment