New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685824 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Security scanner crashes moblab.

Project Member Reported by haddowk@chromium.org, Jan 26 2017

Issue description

When the security scanner sends too many requests to the moblab it runs out of memory, crashes and reboots.

This affects development and testing devices not devices in the lab.

Requests should be efficiently rejected by the moblab.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/420b8d5f68f2c9c7f855578e4f51684624c567b9

commit 420b8d5f68f2c9c7f855578e4f51684624c567b9
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Jan 26 22:50:45 2017

[moblab] Add Apache redirect to protect moblab from security scanner.

Moblab current crashes if the security scanner probes the device, as
it creates too many requests for the available memory.  Since this often
affects testing / developement detect the scanner and return 403.

BUG= chromium:685824 
TEST=Manual testing on my device

Change-Id: Ia7c175f9e5f8283e1d09585ec03a39a1fd457fa9
Reviewed-on: https://chromium-review.googlesource.com/433445
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>

[modify] https://crrev.com/420b8d5f68f2c9c7f855578e4f51684624c567b9/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-apache-settings.conf
[add] https://crrev.com/420b8d5f68f2c9c7f855578e4f51684624c567b9/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r48.ebuild
[delete] https://crrev.com/f7302293319cb4a2e21f67199ef96cfb773ee843/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r47.ebuild

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2017

Labels: merge-merged-release-R56-9000.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4337524dca75a79f85bc5e22a2d2d1584b663e55

commit 4337524dca75a79f85bc5e22a2d2d1584b663e55
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Mar 09 00:26:18 2017

[moblab] Add Apache redirect to protect moblab from security scanner.

Moblab current crashes if the security scanner probes the device, as
it creates too many requests for the available memory.  Since this often
affects testing / developement detect the scanner and return 403.

BUG= chromium:685824 
TEST=Manual testing on my device

Change-Id: Ia7c175f9e5f8283e1d09585ec03a39a1fd457fa9
Reviewed-on: https://chromium-review.googlesource.com/433445
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
(cherry picked from commit 420b8d5f68f2c9c7f855578e4f51684624c567b9)
Reviewed-on: https://chromium-review.googlesource.com/451937
Reviewed-by: Jinjing Liang <jinjingl@google.com>
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/4337524dca75a79f85bc5e22a2d2d1584b663e55/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-apache-settings.conf
[add] https://crrev.com/4337524dca75a79f85bc5e22a2d2d1584b663e55/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r48.ebuild
[delete] https://crrev.com/07262a73cef287bc2d2a515d5d77c9fbb5f4895c/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r47.ebuild

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment