[Remoting Windows] Host should not DCHECK the validity of the touch event input |
|||
Issue descriptionCurrently the Windows host DCHECKs that the touch input is valid and later injects the input assuming that it is well-formed. See: https://cs.chromium.org/chromium/src/remoting/protocol/input_event_tracker.cc?q=touch_point_ids_%5C.find&sq=package:chromium&l=148 In case of invalid input, we should rather test its validity, log a warning, then reject the input.
,
Feb 3 2017
I would recommend: - Testing validity and disconnecting the client if it sends invalid input. - DCHECKing validity as well, so that you will get easily-observed crashes if things break in development builds.
,
Feb 3 2017
I consider DCHECK to be a fairly strong "this should never happen" assertion. So, DCHECKing after input validation (and disconnection) is a good idea, to check that the validation code is working correctly. We shouldn't DCHECK anything from the client before that point, since it's essentially untrusted input. I think disconnection with logging (or, better still, an explicit disconnect reason that gets displayed on the client) is visible enough.
,
Nov 15 2017
Unlikely to be working on soon.
,
Nov 16
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||
►
Sign in to add a comment |
|||
Comment 1 by jamiewa...@chromium.org
, Feb 2 2017Status: Assigned (was: Untriaged)