New issue
Advanced search Search tips

Issue 685821 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

Add should().message()

Project Member Reported by hongchan@chromium.org, Jan 26 2017

Issue description

We had Should().summarize() in the previous Audit, so it is necessary to have the replacement of it - until the transition to the new Audit actually is finished.

should().message(passMessage, failMessage) seems to be an easy fix for this.
 

Comment 1 Deleted

Status: Started (was: Verified)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/700d980db862c9780cd20f64a9527ad07687f51b

commit 700d980db862c9780cd20f64a9527ad07687f51b
Author: hongchan <hongchan@chromium.org>
Date: Fri Jan 27 22:39:01 2017

Implement should().message() for in-task message display

The legacy Audit() had Should().summarize(), so it is sensible to have
the replacement of it in the new Audit - until the transition to the
new Audit actually is finished.

Once the transition is completed, the task runner should be able to
serve the summary and this message() method will not be needed.

BUG= 685821 
TEST=
LayoutTests/webaudio/unit-tests/audit.html
LayoutTests/webaudio/unit-tests/audit-failures.html

Review-Url: https://codereview.chromium.org/2656743005
Cr-Commit-Position: refs/heads/master@{#446801}

[modify] https://crrev.com/700d980db862c9780cd20f64a9527ad07687f51b/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/700d980db862c9780cd20f64a9527ad07687f51b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/700d980db862c9780cd20f64a9527ad07687f51b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt
[modify] https://crrev.com/700d980db862c9780cd20f64a9527ad07687f51b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
[modify] https://crrev.com/700d980db862c9780cd20f64a9527ad07687f51b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Status: Verified (was: Started)

Sign in to add a comment