|using namespace blink| is confusing to rewrite_to_chrome_style |
||
Issue description|using namespace blink| + not putting method definitions under an explicit blink namespace confuses rewrite_to_chrome_style, which renames method declarations in third_party/WebKit/Source/core/html/TimeRanges.h, but doesn't rename names of methods in method definitions in third_party/WebKit/Source/core/html/TimeRanges.cpp.
,
Jan 27 2017
I agree with getting rid of using namespace blink as well
,
Jan 27 2017
Thanks for pointing out that this is a style guide violation - I didn't know that (I've thought that the style guide only bans |using namespace foo| in headers; or maybe I confused this |using foo::Bar| which AFAIK is allowed). I'll go ahead and try to remove this from Blink.
,
Jan 30 2017
CR out @ https://crrev.com/2661493003
,
Feb 1 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by danakj@chromium.org
, Jan 26 2017