New issue
Advanced search Search tips

Issue 685817 link

Starred by 6 users
Status: Fixed
Owner:
lanwei@chromium.org
Closed: May 2017
Cc:
nzolghadr@chromium.org
mustaq@chromium.org
lanwei@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-01-31
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 526153



Sign in to add a comment

Missing pointer ID for stylus pointers on Windows

Project Member Reported by lanwei@chromium.org, Jan 26 2017 
Currently the pointer ID for stylus type on Windows does not setup correctly. Each pointer should get an unique ID in its lifetime, which starts when a pointer comes into a proximity of a tablet and ends when it leaves the proximity range. It will be treated as a new pointer and may be assigned a new pointer identifier when it comes back to the proximity again.

Comment 1 by mustaq@chromium.org, Jan 27 2017

Labels: -OS-iOS -Pri-3 M-58 Pri-2
Let's target M58 for Windows, and use  Issue 685803  to cover the iOS side.

Comment 2 by lanwei@chromium.org, Feb 1 2017

Cc: lanwei@chromium.org
 Issue 616771  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31739e48ae970cbc39e8b8cceb168ca86848150a

commit 31739e48ae970cbc39e8b8cceb168ca86848150a
Author: lanwei <lanwei@chromium.org>
Date: Wed Feb 15 21:29:55 2017

Add id properties to PointerEvent

We add id to PointerDetails which will be used as PointerEvent's pointerId, so we can use it
to keep the id from lower level events from each OS.

In this patch, we also remove touch_id from ui::TouchEvent and pointer_id from ui::PointerEvent,
which are redundant to this new id.

BUG= 685817 

Review-Url: https://codereview.chromium.org/2655303004
Cr-Commit-Position: refs/heads/master@{#450807}

[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ash/host/ash_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ash/touch/touch_hud_debug.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ash/touch/touch_uma.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ash/touch_hud/touch_hud_renderer.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/components/exo/touch.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/content/browser/renderer_host/input/input_router_impl_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/content/common/input/synthetic_web_input_event_builders.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/mash/simple_wm/move_loop.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/services/ui/ws/drag_controller.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/services/ui/ws/event_dispatcher.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/services/ui/ws/event_dispatcher_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/services/ui/ws/window_manager_state.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/aura/env_input_state_controller.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/aura/gestures/gesture_recognizer_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/chromeos/touch_accessibility_enabler.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/chromeos/touch_exploration_controller.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/chromeos/touch_exploration_controller_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/blink/web_input_event_builders_win.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/blink/web_input_event_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/event.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/event.h
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/event_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/events_default.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/gestures/gesture_recognizer_impl.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/gestures/motion_event_aura.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/gestures/motion_event_aura_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/test/event_generator.cc
[modify] https://crrev.com/31739e48ae970cbc39e8b8cceb168ca86848150a/ui/events/x/events_x.cc

Comment 4 by lanwei@chromium.org, May 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment