Migrate DCHECK_AT into base/logging.h |
||
Issue descriptionBlink's wtf/Assertions.h defines DCHECK_AT(), a variant which allows the file and line-number parameters to be supplied explicitly. This is used to have DCHECKs on unexpected exception throwing call out the code that threw the exception, rather than the exception code itself. We should fold DCHECK_AT into base/logging.h and have DCHECK() become just shorthand for it, rather than maintaining parallel and (over time) subtley different implementations.
,
Jan 26 2017
DCHECK_AT is used in 4 files. We shouldn't make logging.h (which is already to long) longer for that.
,
Feb 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by w...@chromium.org
, Jan 26 2017