New issue
Advanced search Search tips

Issue 685811 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Migrate DCHECK_AT into base/logging.h

Project Member Reported by w...@chromium.org, Jan 26 2017

Issue description

Blink's wtf/Assertions.h defines DCHECK_AT(), a variant which allows the file and line-number parameters to be supplied explicitly.  This is used to have DCHECKs on unexpected exception throwing call out the code that threw the exception, rather than the exception code itself.

We should fold DCHECK_AT into base/logging.h and have DCHECK() become just shorthand for it, rather than maintaining parallel and (over time) subtley different implementations.
 

Comment 1 by w...@chromium.org, Jan 26 2017

Labels: M-58

Comment 2 by thakis@chromium.org, Jan 26 2017

DCHECK_AT is used in 4 files. We shouldn't make logging.h (which is already to long) longer for that.

Comment 3 by w...@chromium.org, Feb 25 2017

Status: WontFix (was: Assigned)

Sign in to add a comment